junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

skipped cohort certs are logged without failing the coordinator SubTask 🟩

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-06-24 11:11:19 +00:00
parent fc2732550c
commit e1bc5360f2
2 changed files with 6 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
applications/modelling_e2e/handler.py
View file

@ -25,7 +25,6 @@ from __future__ import annotations
import dataclasses import dataclasses
import io import io
import json
import os import os
from collections.abc import Callable from collections.abc import Callable
from typing import Any, Optional, cast from typing import Any, Optional, cast
@ -460,9 +459,5 @@ def handler(body: dict[str, Any], context: Any, orchestrator: TaskOrchestrator,
f"{[s['certificate_number'] for s in skipped_certs]}" f"{[s['certificate_number'] for s in skipped_certs]}"
) )
if skipped_certs:
raise RuntimeError(
f"skipped_unmappable_cohort_certs: {json.dumps(skipped_certs)}"
)
finally: finally:
read_session.close() read_session.close()

21
tests/applications/modelling_e2e/test_handler.py
View file

@ -293,12 +293,9 @@ def test_lodged_epc_path_saves_epc_plan_and_marks_modelled(
_baseline_orchestrator.return_value.run.assert_called_once_with([PROPERTY_ID]) _baseline_orchestrator.return_value.run.assert_called_once_with([PROPERTY_ID])
def test_skipped_cohort_certs_fail_the_subtask_but_the_plan_is_still_saved() -> None: def test_skipped_cohort_certs_do_not_prevent_plan_being_saved() -> None:
"""Cohort certs the mapper can't consume are skipped (so prediction is not """Cohort certs the mapper can't consume are skipped so prediction can
aborted), then surfaced as a failure — the subtask is marked failed (the proceed — the property's plan is committed before the handler returns."""
cert numbers land in outputs.error via the raised RuntimeError) so the
mapper gaps get debugged. The batch still ran to completion first, so the
property's plan was committed before the handler raised."""
from repositories.comparable_properties.epc_comparable_properties_repository import ( from repositories.comparable_properties.epc_comparable_properties_repository import (
SkippedCohortCert, SkippedCohortCert,
) )
@ -372,16 +369,10 @@ def test_skipped_cohort_certs_fail_the_subtask_but_the_plan_is_still_saved() ->
MockUoW.return_value.__enter__.return_value = mock_uow MockUoW.return_value.__enter__.return_value = mock_uow
MockUoW.return_value.__exit__.return_value = False MockUoW.return_value.__exit__.return_value = False
# Act — the skipped cert fails the subtask, but only after the batch ran. # Act — no raise even with a skipped cert
with pytest.raises(RuntimeError) as excinfo: _call_handler(_BODY)
_call_handler(_BODY)
# Assert — the cert number + error reach outputs.error (the raised message), # Assert — plan committed despite the skipped cert
# and the property's plan was still committed before the handler raised.
message = str(excinfo.value)
assert "skipped_unmappable_cohort_certs" in message
assert "8257-7539-1649-0633-4992" in message
assert "RdSapSchema17_1: missing required field 'window'" in message
mock_uow.plan.save.assert_called_once() mock_uow.plan.save.assert_called_once()
mock_uow.commit.assert_called_once() mock_uow.commit.assert_called_once()