removed todo

This commit is contained in:
Khalim Conn-Kowlessar 2023-12-21 11:23:30 +00:00
parent fceb6a1d96
commit e65d190e19
5 changed files with 4 additions and 11 deletions

2
.idea/Model.iml generated
View file

@ -7,7 +7,7 @@
<sourceFolder url="file://$MODULE_DIR$/open_uprn" isTestSource="false" />
<sourceFolder url="file://$MODULE_DIR$/recommendations" isTestSource="false" />
</content>
<orderEntry type="jdk" jdkName="Python 3.10 (backend)" jdkType="Python SDK" />
<orderEntry type="jdk" jdkName="Python 3.10 (model_data)" jdkType="Python SDK" />
<orderEntry type="sourceFolder" forTests="false" />
</component>
<component name="PyNamespacePackagesService">

2
.idea/misc.xml generated
View file

@ -3,7 +3,7 @@
<component name="Black">
<option name="sdkName" value="Python 3.10 (backend)" />
</component>
<component name="ProjectRootManager" version="2" project-jdk-name="Python 3.10 (backend)" project-jdk-type="Python SDK" />
<component name="ProjectRootManager" version="2" project-jdk-name="Python 3.10 (model_data)" project-jdk-type="Python SDK" />
<component name="PythonCompatibilityInspectionAdvertiser">
<option name="version" value="3" />
</component>

View file

@ -118,19 +118,12 @@ async def trigger_plan(body: PlanTriggerRequest):
logger.info("Getting components and epc recommendations")
# TODO: Move this to a class. We probably want a Recommender class which takes the injects the optimisers
# in as a dependency and then the optimisers can take the input measures in as part of the setup() method
recommendations = {}
recommendations_scoring_data = []
property_scoring_data = {}
for p in input_properties:
# TODO: TEMP
if p.address1 == "The Hollies Farm House, Church Walk, Little Dalby":
continue
# Property recommendations
p.get_components(cleaned)

View file

@ -178,7 +178,7 @@ def create_recommendation_scoring_data(
if recommendation["type"] == "windows_glazing":
scoring_dict["MULTI_GLAZE_PROPORTION_ENDING"] = 100
scoring_dict["WINDOWS_ENERGY_EFF_ENDING"] = "Average"
if scoring_dict["glazing_type_ENDING"] == "multiple":
if scoring_dict["glazing_type_ENDING"] in ["multiple", "double"]:
pass
else:
raise NotImplementedError("Implement me")

View file

@ -19,7 +19,7 @@ def app():
[
{"address": "3 Church Terrace", "postcode": "LE13 0PW", "Notes": None},
{"address": "3, Main Street, Redmile", "postcode": "NG13 0GA", "Notes": None},
{"address": "The Hollies Farm House, Church Walk, Little Dalby", "postcode": "LE14 2UQ", "Notes": None},
{"address": "Manor House, Kennel Lane, Reepham", "postcode": "LN3 4DZ", "Notes": None},
{"address": "13 Main Street", "postcode": "LE14 2JU", "Notes": None},
{"address": "8 The Crescent, Coston Road, Buckminster", "postcode": "NG33 5SF", "Notes": None},
]