junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Slice 44: flat_roof_insulation_thickness mapper fix — surface lodged value on SapBuildingPart

Browse source 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-05-24 15:28:10 +00:00
parent a05ecacd67
commit ea6d426349
3 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
datatypes/epc/domain/mapper.py
View file

@ -730,6 +730,7 @@ class EpcPropertyDataMapper:
wall_insulation_thickness=bp.wall_insulation_thickness,
floor_heat_loss=bp.floor_heat_loss,
floor_insulation_thickness=bp.floor_insulation_thickness,
flat_roof_insulation_thickness=bp.flat_roof_insulation_thickness,
roof_construction=bp.roof_construction,
roof_insulation_location=bp.roof_insulation_location,
roof_insulation_thickness=bp.roof_insulation_thickness,
@ -875,6 +876,7 @@ class EpcPropertyDataMapper:
wall_insulation_thickness=bp.wall_insulation_thickness,
floor_heat_loss=bp.floor_heat_loss,
floor_insulation_thickness=bp.floor_insulation_thickness,
flat_roof_insulation_thickness=bp.flat_roof_insulation_thickness,
roof_construction=bp.roof_construction,
roof_insulation_location=bp.roof_insulation_location,
roof_insulation_thickness=bp.roof_insulation_thickness,
@ -1037,6 +1039,7 @@ class EpcPropertyDataMapper:
wall_insulation_thickness=bp.wall_insulation_thickness,
floor_heat_loss=bp.floor_heat_loss,
floor_insulation_thickness=bp.floor_insulation_thickness,
flat_roof_insulation_thickness=bp.flat_roof_insulation_thickness,
roof_construction=bp.roof_construction,
roof_insulation_location=bp.roof_insulation_location,
roof_insulation_thickness=bp.roof_insulation_thickness,
@ -1226,6 +1229,7 @@ class EpcPropertyDataMapper:
wall_insulation_thickness=bp.wall_insulation_thickness,
floor_heat_loss=bp.floor_heat_loss,
floor_insulation_thickness=bp.floor_insulation_thickness,
flat_roof_insulation_thickness=bp.flat_roof_insulation_thickness,
roof_construction=bp.roof_construction,
roof_insulation_location=bp.roof_insulation_location,
roof_insulation_thickness=bp.roof_insulation_thickness,
@ -1484,6 +1488,7 @@ class EpcPropertyDataMapper:
wall_insulation_thickness=bp.wall_insulation_thickness,
floor_heat_loss=bp.floor_heat_loss,
floor_insulation_thickness=bp.floor_insulation_thickness,
flat_roof_insulation_thickness=bp.flat_roof_insulation_thickness,
roof_construction=bp.roof_construction,
roof_insulation_location=bp.roof_insulation_location,
roof_insulation_thickness=bp.roof_insulation_thickness,

15
datatypes/epc/domain/tests/test_from_rdsap_schema.py
View file

@ -589,6 +589,21 @@ class TestFromRdSapSchema21_0_1:
# --- room-in-roof (sap_room_in_roof.room_in_roof_type_1) ---
def test_flat_roof_insulation_thickness_flows_through_on_building_part(
self, result: EpcPropertyData
) -> None:
# Arrange — schema-21.0.1 lodges flat_roof_insulation_thickness
# on SapBuildingPart as a categorical code (e.g. "AB" for "As
# Built"). EpcPropertyData.SapBuildingPart declares the field;
# without mapper passthrough the flat-roof U-value cascade has
# no insulation signal to use.
# Act
v = result.sap_building_parts[0].flat_roof_insulation_thickness
# Assert
assert v == "AB"
def test_sap_room_in_roof_gable_lengths_extracted_from_room_in_roof_type_1(
self, result: EpcPropertyData
) -> None:

1
datatypes/epc/schema/tests/fixtures/21_0_1.json vendored
View file

@ -139,6 +139,7 @@
"roof_construction": 4,
"wall_construction": 4,
"building_part_number": 1,
"flat_roof_insulation_thickness": "AB",
"sap_floor_dimensions": [
{
"floor": 0,