Merge pull request #1675 from Hestia-Homes/chore/stop-writing-flat-room-in-roof

Stop writing the superseded flat room-in-roof columns (pre-drop step)
This commit is contained in:
KhalimCK 2026-07-24 14:32:30 +01:00 committed by GitHub
commit eb949ed863
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -685,8 +685,6 @@ class EpcBuildingPartModel(SQLModel, table=True):
# (-2.32 SAP). The prior allowlist "RdSAP uses defaults" was stale — the
# cascade does honour the lodged U on the API path.
wall_u_value: Optional[float] = Field(default=None)
room_in_roof_floor_area: Optional[float] = Field(default=None)
room_in_roof_construction_age_band: Optional[str] = Field(default=None)
alt_wall_1_area: Optional[float] = Field(default=None)
alt_wall_1_dry_lined: Optional[str] = Field(default=None)
alt_wall_1_construction: Optional[int] = Field(default=None)
@ -715,7 +713,6 @@ class EpcBuildingPartModel(SQLModel, table=True):
def from_domain(
cls, part: SapBuildingPart, epc_property_id: int
) -> EpcBuildingPartModel:
rir = part.sap_room_in_roof
aw1 = part.sap_alternative_wall_1
aw2 = part.sap_alternative_wall_2
return cls(
@ -746,10 +743,6 @@ class EpcBuildingPartModel(SQLModel, table=True):
rafter_insulation_thickness=part.rafter_insulation_thickness,
wall_is_basement=part.wall_is_basement,
wall_u_value=part.wall_u_value,
room_in_roof_floor_area=float(rir.floor_area) if rir else None,
room_in_roof_construction_age_band=(
rir.construction_age_band if rir else None
),
alt_wall_1_area=aw1.wall_area if aw1 else None,
alt_wall_1_dry_lined=aw1.wall_dry_lined if aw1 else None,
alt_wall_1_construction=aw1.wall_construction if aw1 else None,