junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1044 from Hestia-Homes/bug_fix/unset_deal_properties_doesnt_overwrite_value_in_db

Browse source 
Bug fix/unset deal properties doesnt overwrite value in db
This commit is contained in:
Jun-te Kim 2026-05-01 14:53:41 +01:00 • committed by GitHub
commit f3032b9d44
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 41 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
etl/hubspot/hubspotDataTodB.py
View file

@ -95,8 +95,12 @@ class HubspotDataToDb:
with db_read_session() as session:
deal_id = deal_data.get("hs_object_id")
self._sync_owner_to_db(deal_data.get("coordinator_user"), hubspot_client, session)
self._sync_owner_to_db(deal_data.get("designer_user"), hubspot_client, session)
self._sync_owner_to_db(
deal_data.get("coordinator_user"), hubspot_client, session
)
self._sync_owner_to_db(
deal_data.get("designer_user"), hubspot_client, session
)
statement = select(HubspotDealData).where(
HubspotDealData.deal_id == deal_id
@ -256,7 +260,7 @@ class HubspotDataToDb:
),
"domna_survey_date": parse_hs_date(deal_data.get("osmosis_survey_date")),
}.items():
setattr(existing, attr, value or getattr(existing, attr))
setattr(existing, attr, value)
def _build_new_deal(
self,

34
etl/hubspot/tests/test_hubspot_data_to_db.py Normal file
View file

@ -0,0 +1,34 @@
from etl.hubspot.hubspotDataTodB import HubspotDataToDb
from backend.app.db.models.hubspot_deal_data import HubspotDealData
def _make_instance() -> HubspotDataToDb:
return HubspotDataToDb.__new__(HubspotDataToDb)
def test_update_existing_deal__designer_cleared_to_none__overwrites_existing() -> None:
existing = HubspotDealData(deal_id="MOCK_DEAL_ID", designer="Old Designer")
deal_data = {"designer_user": None}
_make_instance()._update_existing_deal(
existing=existing,
deal_data=deal_data,
listing=None,
company=None,
)
assert existing.designer is None
def test_update_existing_deal__designer_set__overwrites_existing() -> None:
existing = HubspotDealData(deal_id="MOCK_DEAL_ID", designer="Old Designer")
deal_data = {"designer_user": "New Designer"}
_make_instance()._update_existing_deal(
existing=existing,
deal_data=deal_data,
listing=None,
company=None,
)
assert existing.designer == "New Designer"