junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-27 23:35:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix stale comments referencing the removed default-resource fallback

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-17 13:20:47 +00:00
parent edd4ec00de
commit f32628b293
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
etl/hubspot/hubspot_deal_differ.py
View file

@ -268,8 +268,8 @@ class HubspotDealDiffer:
),
"confirmed_survey_time": new_deal.get("confirmed_survey_time"),
# Carried for the log/amend flows: sent to OpenHousing as the
# bookable resource, falling back to the configured default
# surveyor when absent.
# bookable resource. Mandatory for those flows — a deal without
# it fails the message contract's validation and dead-letters.
"third_party_surveyor_identifier": new_deal.get(
"third_party_surveyor_identifier"
),

4
tests/orchestration/test_abri_orchestrator_amend_job.py
View file

@ -126,8 +126,8 @@ def test_amend_job_books_the_deals_third_party_surveyor_as_the_resource(
mock_session: MagicMock,
deal_database: FakeDealDatabase,
) -> None:
# Arrange: a deal carrying a third-party surveyor identifier amends the
# appointment against that resource instead of the configured default.
# Arrange: the deal's third-party surveyor identifier is booked as the
# amended appointment's resource.
deal_database.job_nos[DEAL_ID] = JOB_NO
mock_session.post.return_value.content = _load_fixture(
"abri_relay_amendoptiappt_success_response.xml"

4
tests/orchestration/test_abri_orchestrator_log_job.py
View file

@ -145,8 +145,8 @@ def test_log_job_sends_a_logjob_envelope_built_from_the_deals_fields(
def test_log_job_books_the_deals_third_party_surveyor_as_the_resource(
orchestrator: AbriOrchestrator, mock_session: MagicMock
) -> None:
# Arrange: a deal carrying a third-party surveyor identifier books the
# job against that resource instead of the configured default surveyor.
# Arrange: the deal's third-party surveyor identifier is booked as the
# job's resource.
mock_session.post.return_value.content = _load_fixture(
"abri_relay_logjob_success_response.xml"
)