replace incorrect tests 🟩

This commit is contained in:
Daniel Roth 2026-04-08 16:04:30 +00:00
parent 2d0bc67731
commit f719149c03

View file

@ -165,40 +165,6 @@ def test_pashub_trigger__coordination_completed_and_pashub_link_not_set__returns
assert actual_output == expected_output
def test_pashub_trigger__coordination_status_not_completed_and_pashub_link_set__returns_false() -> (
None
):
# arrange
deal_id = uuid.uuid4()
old_deal = HubspotDealData(
id=deal_id,
deal_id="1",
pashub_link="www.google.co.uk",
coordination_status="random",
created_at=datetime(2025, 12, 1, 12, 0, 0),
updated_at=datetime(2025, 12, 1, 12, 0, 0),
)
new_deal: Dict[str, str] = {
"id": str(deal_id),
"deal_id": "1",
"coordination_status": "not complete",
"pashub_link": "www.google.co.uk",
"created_at": datetime(2025, 12, 1, 12, 0, 0).isoformat(),
"updated_at": datetime(2025, 12, 1, 12, 30, 0).isoformat(),
}
expected_output = False
# act
actual_output: bool = HubspotDealDiffer.check_for_pashub_trigger(
new_deal=new_deal, old_deal=old_deal
)
# assert
assert actual_output == expected_output
def test_pashub_trigger__design_completed_and_pashub_link_set__returns_true() -> None:
# arrange
deal_id = uuid.uuid4()
@ -261,39 +227,6 @@ def test_pashub_trigger__design_completed_and_pashub_link_not_set__returns_false
assert actual_output == expected_output
def test_pashub_trigger__design_not_completed_and_pashub_link_set__returns_false() -> (
None
):
# arrange
deal_id = uuid.uuid4()
old_deal = HubspotDealData(
id=deal_id,
deal_id="1",
pashub_link="www.google.co.uk",
created_at=datetime(2025, 12, 1, 12, 0, 0),
updated_at=datetime(2025, 12, 1, 12, 0, 0),
)
new_deal: Dict[str, str] = {
"id": str(deal_id),
"deal_id": "1",
"pashub_link": "www.google.co.uk",
"design_status": "not uploaded",
"created_at": datetime(2025, 12, 1, 12, 0, 0).isoformat(),
"updated_at": datetime(2025, 12, 1, 12, 30, 0).isoformat(),
}
expected_output = False
# act
actual_output: bool = HubspotDealDiffer.check_for_pashub_trigger(
new_deal=new_deal, old_deal=old_deal
)
# assert
assert actual_output == expected_output
def test_pashub_trigger__lodgement_completed_and_pashub_link_set__returns_true() -> (
None
):
@ -391,7 +324,7 @@ def test_pashub_trigger__lodgement_completed_and_pashub_link_not_set__returns_fa
assert actual_output == expected_output
def test_pashub_trigger__lodgement_not_completed_and_pashub_link_set__returns_false() -> (
def test_pashub_trigger__coordination_design_lodgement_not_completed_and_pashub_link_set__returns_false() -> (
None
):
# arrange
@ -408,7 +341,9 @@ def test_pashub_trigger__lodgement_not_completed_and_pashub_link_set__returns_fa
"id": str(deal_id),
"deal_id": "1",
"pashub_link": "www.google.co.uk",
"lodgement_status": "lodgement not complete",
"coordination_status": "not uploaded",
"design_status": "not uploaded",
"lodgement_status": "not uploaded",
"created_at": datetime(2025, 12, 1, 12, 0, 0).isoformat(),
"updated_at": datetime(2025, 12, 1, 12, 30, 0).isoformat(),
}