get_evidence_files_by_job_id returns DownloadedFiles with empty other when include_other=False 🟩

backend/pashub_fetcher/pashub_client.py

@@ -83,7 +83,28 @@ class PashubClient:
     def get_evidence_files_by_job_id(
         self, job_id: str, include_other: bool = False
     ) -> DownloadedFiles:
-        raise NotImplementedError
+        logger.info(f"Getting evidence files for job ID {job_id}")
+        evidence_list: List[EvidenceFileData] = self._get_evidence_list(job_id)
+        logger.info(f"Found {len(evidence_list)} evidence files")
+        if not evidence_list:
+            return DownloadedFiles(core=[], other=[])
+
+        grouped = self._group_into_core_and_other_files(evidence_list)
+
+        core_paths: List[str] = []
+        for _, evidence in grouped.core.items():
+            if not evidence.file_id:
+                continue
+            metadata: EvidenceMetadata = self._get_evidence_metadata(
+                job_id, evidence.file_id
+            )
+            download_url: str = self._build_download_url(metadata, evidence.file_id)
+            file_path: str = os.path.join("/tmp", evidence.file_name)
+            self._download_file(download_url, file_path)
+            logger.info("Successfully downloaded file")
+            core_paths.append(file_path)
+
+        return DownloadedFiles(core=core_paths, other=[])
 
     def get_uprn_by_job_id(self, job_id: str) -> Optional[str]:
         logger.info(f"Getting UPRN for job ID {job_id}")