From fa72d162395f3e70c34600757afda49c98cacdd1 Mon Sep 17 00:00:00 2001 From: Daniel Roth Date: Thu, 22 Jan 2026 15:21:31 +0000 Subject: [PATCH] small tidies --- .../condition/domain/mapping/{ => lbwf}/lbwf_mapper.py | 0 .../domain/mapping/{ => peabody}/peabody_mapper.py | 1 - backend/condition/parsing/factory.py | 8 +++++--- backend/condition/processor.py | 5 +++-- backend/condition/tests/mapping/test_lbwf_mapper.py | 3 +-- backend/condition/tests/mapping/test_peabody_mapper.py | 3 +-- 6 files changed, 10 insertions(+), 10 deletions(-) rename backend/condition/domain/mapping/{ => lbwf}/lbwf_mapper.py (100%) rename backend/condition/domain/mapping/{ => peabody}/peabody_mapper.py (90%) diff --git a/backend/condition/domain/mapping/lbwf_mapper.py b/backend/condition/domain/mapping/lbwf/lbwf_mapper.py similarity index 100% rename from backend/condition/domain/mapping/lbwf_mapper.py rename to backend/condition/domain/mapping/lbwf/lbwf_mapper.py diff --git a/backend/condition/domain/mapping/peabody_mapper.py b/backend/condition/domain/mapping/peabody/peabody_mapper.py similarity index 90% rename from backend/condition/domain/mapping/peabody_mapper.py rename to backend/condition/domain/mapping/peabody/peabody_mapper.py index 4c647380..8413b888 100644 --- a/backend/condition/domain/mapping/peabody_mapper.py +++ b/backend/condition/domain/mapping/peabody/peabody_mapper.py @@ -1,7 +1,6 @@ from typing import Any, List, Optional from backend.condition.domain.asset_condition import AssetCondition -from backend.condition.domain.lbwf_element import LbwfElement from backend.condition.domain.mapping.mapper import Mapper from backend.condition.parsing.records.peabody.peabody_asset_condition import ( PeabodyAssetCondition, diff --git a/backend/condition/parsing/factory.py b/backend/condition/parsing/factory.py index 3a28df78..7233a1df 100644 --- a/backend/condition/parsing/factory.py +++ b/backend/condition/parsing/factory.py @@ -1,21 +1,23 @@ -from backend.condition.domain.mapping.lbwf_mapper import LbwfMapper +from backend.condition.domain.mapping.lbwf.lbwf_mapper import LbwfMapper from backend.condition.domain.mapping.mapper import Mapper from backend.condition.file_type import FileType from backend.condition.parsing.parser import Parser from backend.condition.parsing.lbwf_parser import LbwfParser from backend.condition.parsing.peabody_parser import PeabodyParser + def select_parser(file_type: FileType) -> Parser: if file_type is FileType.LBWF: return LbwfParser() - + if file_type is FileType.Peabody: return PeabodyParser() raise ValueError("Unrecognised file type, unable to instantiate Parser") + def select_mapper(file_type: FileType) -> Mapper: if file_type is FileType.LBWF: return LbwfMapper() - + raise ValueError("Unrecognised file type, unable to instantiate Mapper") diff --git a/backend/condition/processor.py b/backend/condition/processor.py index cc44e38a..a48e22f4 100644 --- a/backend/condition/processor.py +++ b/backend/condition/processor.py @@ -8,6 +8,7 @@ from utils.logger import setup_logger from backend.condition.file_type import FileType, detect_file_type from backend.condition.parsing.factory import select_parser, select_mapper + def process_file(file_stream: BinaryIO, source_key: str) -> None: print(f"[processor] Received file: {source_key}") @@ -19,10 +20,10 @@ def process_file(file_stream: BinaryIO, source_key: str) -> None: # Orchestration raw_properties: List[Any] = parser.parse(file_stream) - survey_year = datetime.now().year # TODO: get this from filepath or elsewhere + survey_year = datetime.now().year # TODO: get this from filepath or elsewhere assets: List[AssetCondition] = [] for p in raw_properties: assets.extend(mapper.map_asset_conditions_for_property(p, survey_year)) - print(assets) # temp \ No newline at end of file + print(assets) # temp diff --git a/backend/condition/tests/mapping/test_lbwf_mapper.py b/backend/condition/tests/mapping/test_lbwf_mapper.py index f930fdb4..f4266ac4 100644 --- a/backend/condition/tests/mapping/test_lbwf_mapper.py +++ b/backend/condition/tests/mapping/test_lbwf_mapper.py @@ -5,12 +5,11 @@ from datetime import date from backend.condition.domain.aspect_type import AspectType from backend.condition.domain.element import Element -from backend.condition.domain.mapping.lbwf_mapper import LbwfMapper +from backend.condition.domain.mapping.lbwf.lbwf_mapper import LbwfMapper from backend.condition.parsing.records.lbwf.lbwf_house import LbwfHouse from backend.condition.parsing.records.lbwf.lbwf_asset_condition import ( LbwfAssetCondition, ) -from backend.condition.domain.lbwf_element import LbwfElement from backend.condition.domain.asset_condition import AssetCondition diff --git a/backend/condition/tests/mapping/test_peabody_mapper.py b/backend/condition/tests/mapping/test_peabody_mapper.py index 2d2446e5..de027fe7 100644 --- a/backend/condition/tests/mapping/test_peabody_mapper.py +++ b/backend/condition/tests/mapping/test_peabody_mapper.py @@ -1,7 +1,6 @@ from datetime import datetime -from backend.condition.domain.mapping.peabody_mapper import PeabodyMapper -from backend.condition.domain.lbwf_element import LbwfElement +from backend.condition.domain.mapping.peabody.peabody_mapper import PeabodyMapper from backend.condition.parsing.records.peabody.peabody_asset_condition import ( PeabodyAssetCondition, )