reduce interdependencies

This commit is contained in:
Khalim Conn-Kowlessar 2023-07-19 14:37:57 +01:00
parent 87ef9bb5dc
commit ff180a67e2
3 changed files with 4 additions and 6 deletions

2
.idea/Model.iml generated
View file

@ -5,7 +5,7 @@
<sourceFolder url="file://$MODULE_DIR$/backend" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/backend" isTestSource="false" />
<sourceFolder url="file://$MODULE_DIR$/model_data" isTestSource="false" /> <sourceFolder url="file://$MODULE_DIR$/model_data" isTestSource="false" />
</content> </content>
<orderEntry type="jdk" jdkName="Python 3.10 (BackendApi)" jdkType="Python SDK" /> <orderEntry type="jdk" jdkName="Python 3.10 fastapi" jdkType="Python SDK" />
<orderEntry type="sourceFolder" forTests="false" /> <orderEntry type="sourceFolder" forTests="false" />
</component> </component>
</module> </module>

2
.idea/misc.xml generated
View file

@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?> <?xml version="1.0" encoding="UTF-8"?>
<project version="4"> <project version="4">
<component name="ProjectRootManager" version="2" project-jdk-name="Python 3.10 (BackendApi)" project-jdk-type="Python SDK" /> <component name="ProjectRootManager" version="2" project-jdk-name="Python 3.10 fastapi" project-jdk-type="Python SDK" />
<component name="PythonCompatibilityInspectionAdvertiser"> <component name="PythonCompatibilityInspectionAdvertiser">
<option name="version" value="3" /> <option name="version" value="3" />
</component> </component>

View file

@ -2,8 +2,6 @@ from datetime import datetime
import re import re
from epc_api.client import EpcClient from epc_api.client import EpcClient
from model_data.config import EPC_AUTH_TOKEN from model_data.config import EPC_AUTH_TOKEN
from model_data.OpenUprnClient import OpenUprnClient
from model_data.EpcClean import EpcClean
from model_data.BaseUtility import BaseUtility from model_data.BaseUtility import BaseUtility
@ -70,7 +68,7 @@ class Property(BaseUtility):
self.data = response["rows"][0] self.data = response["rows"][0]
def get_coordinates(self, open_uprn_client: OpenUprnClient): def get_coordinates(self, open_uprn_client):
""" """
This method utlises the OpenOprnClient to get the coordinates of the property This method utlises the OpenOprnClient to get the coordinates of the property
The OpenOprnClient interfactes with the Ordinance Survey Open UPRN database to extract The OpenOprnClient interfactes with the Ordinance Survey Open UPRN database to extract
@ -89,7 +87,7 @@ class Property(BaseUtility):
self.coordinates = {key.lower(): value for key, value in self.coordinates.items()} self.coordinates = {key.lower(): value for key, value in self.coordinates.items()}
def get_components(self, cleaner: EpcClean): def get_components(self, cleaner):
""" """
Given the cleaning that has been performed, we'll use this to identify the property Given the cleaning that has been performed, we'll use this to identify the property
components, from roof to walls to windows, heating and hot water components, from roof to walls to windows, heating and hot water