mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
f68cea27c9
The Modelling glazing overlay's draught-proofing recompute (RdSAP 10 §8.1 — a count over openable windows + doors) needs every openable window captured with its draught_proofed flag. cert 001431's §11 lodges 17 windows but only 14 surfaced, via two distinct gaps: 1. Extractor (_extract_windows_from_layout): the one "Double glazing, known data" row whose §11 Data-Source cell is "BFRC data" was rejected — it is laid out as a standalone keyword line with the U-value on the next line and lodges no Frame Type/Factor/Gap cells, so it never matched the joined "<source> <U>" Manufacturer-line shape. Now anchored by a standalone data-source form, with the RdSAP 10 §3.7 default frame factor (0.7) for the absent frame cell. 2. Mapper (_is_elmhurst_roof_window): the two "Double pre 2002" rows (U 3.1 / 3.4 > 3.0) were reclassified as roof windows by the U-value backstop even though both are lodged on an "External wall". A window lodged on a wall is vertical by definition; guard the U-value backstop so it only fires when location/BP give no roof signal. The backstop's only pinned cert (000516 W6) hand-builds its sap_roof_windows and so is unaffected. With both closed: 17 sap_windows, 0 misrouted to sap_roof_windows, 14 draught-proofed — reconstructing Elmhurst's lodged 84% (16/19 = (14 windows + 2 doors) / (17 windows + 2 doors)). Full calculator + modelling + orchestration suites green (1885 pass); the 2 glazing draught-proofing xfails remain (the overlay recompute is the glazing agent's front). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| __init__.py | ||
| _elmhurst_recommendation.py | ||
| test_elmhurst_cascade_pins.py | ||
| test_floor_recommendation.py | ||
| test_glazing_recommendation.py | ||
| test_lighting_recommendation.py | ||
| test_measure_dependency.py | ||
| test_optimiser.py | ||
| test_overlay_applicator.py | ||
| test_package_scorer.py | ||
| test_plan.py | ||
| test_plan_valuation.py | ||
| test_roof_recommendation.py | ||
| test_scoring.py | ||
| test_valuation.py | ||
| test_ventilation_recommendation.py | ||
| test_wall_recommendation.py | ||
| test_window_extraction_001431.py | ||