mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
a6b798218f
`test_epc_property_data_round_trips[RdSAP-Schema-21.0.1]` failed with `sap_roof_windows: None != []` — a normalization mismatch, not lost data. The 21.0.1 fixture has no roof windows, but the 21.0.1 API mapper emitted an empty list `[]` while the domain field defaults to None (`Optional[List[SapRoofWindow]] = None`), the 21.0.0 path yields None, and the persistence reload yields None (roof windows aren't stored yet — doc §2.4). Append `or None` so "no roof windows" has one canonical representation across mapper paths and the round-trip. No data-loss change: a cert WITH roof windows still produces the populated list (test_golden_fixtures pins a 6-roof-window cert), and the §2.4 roof-window persistence gap remains separately tracked. Full sap10_calculator + documents_parser + epc-repository suites pass (2420); pyright unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| tests | ||
| __init__.py | ||
| epc.py | ||
| epc_codes.csv | ||
| epc_property_data.py | ||
| field_mappings.py | ||
| historic_epc.py | ||
| historic_epc_matching.py | ||
| mapper.py | ||