mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00

History

Khalim Conn-Kowlessar 06ce3205b1 slice 17a: PV-export credit in predicted_total_fuel_cost (v2.1.0) Closes the high-SAP under-prediction gap diagnosed in 16h. 40% of SAP-85+ properties have PV; predicted_ecf was 1.74 mean at that band -> SAP ~88 via the formula, vs label SAP 90+. Inverse: PV homes had HIGHER predicted_ecf than non-PV at the same band because cost reconstruction had zero export credit. New helper: predicted_pv_generation_kwh(kWp, region) -> kWh/yr from a SAP10.2 Table 6e regional yield factor (UK avg 850 kWh/kWp/yr; Highland 650; Thames 920). predicted_total_fuel_cost_gbp now subtracts pv_kwh * standard electricity price (Table 32 code 30, both self-consumption and export at 13.19 p/kWh). New feature column predicted_pv_generation_kwh exposed alongside the adjusted cost so the model sees both signals. VERSION 2.0.0 -> 2.1.0 (MINOR: column added; existing column semantics shifted but pre-deploy so no consumer break).		2026-05-17 15:28:09 +00:00
..
src/domain	slice 17a: PV-export credit in predicted_total_fuel_cost (v2.1.0)	2026-05-17 15:28:09 +00:00
pyproject.toml	slice 13: to_rows(properties) returns pd.DataFrame	2026-05-16 16:43:28 +00:00
README.md	added potential file scaffolding:	2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.