mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00

History

Khalim Conn-Kowlessar 171cb97c6e e2e: SAP-score regression test against both Elmhurst worksheets First end-to-end test running EpcPropertyData → cert_to_inputs → calculate_sap_from_inputs → SapResult and comparing against the Elmhurst worksheet's headline SAP rating (line 258). Current state: 000490 mid-terrace gas combi, time-clock keep-hot SAP rating: 57 = 57 ✓ exact integer match Continuous: 56.72 vs 57.40 → 0.7 points off (rounding noise) 000474 end-terrace gas combi, PCDB Vaillant ecoTEC pro SAP rating: 55 vs 62 → 7 points UNDER Space heating: 12299.6 vs 10612.9 (+16%) Hot water: 3020.0 vs 2291.8 (+32%) The 000474 gap localises to (a) the legacy hot-water cascade not knowing about PCDB Table 3b combi loss (over-estimates HW by 32%) and (b) likely a downstream space-heating-efficiency consequence. Both will shrink once the §4 worksheet orchestrator + Table 3b are wired into cert_to_inputs. Tolerances set at the CURRENT gap so subsequent improvements show up as tightening, not silent drift. The 000474 ceiling drops to ≤2 SAP points once the worksheet §4 path lands in the mapper. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>		2026-05-20 16:27:04 +00:00
..
src/domain	e2e: SAP-score regression test against both Elmhurst worksheets	2026-05-20 16:27:04 +00:00
pyproject.toml	slice 13: to_rows(properties) returns pd.DataFrame	2026-05-16 16:43:28 +00:00
README.md	added potential file scaffolding:	2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.