mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
A SAP-Schema-17.0 full-SAP cohort cert (8265-7433-3220-9736-7902) omits the top-level `has_hot_water_cylinder` and lodges it only under `sap_heating`. The required top-level field on SapSchema17_1 made `from_dict` raise and skip the cert. Fix: make the top-level field Optional, and have the full-SAP mapper (`from_sap_schema_17_1`, also used by 17.0/18.0.0 via delegation) fall back to `sap_heating.has_hot_water_cylinder`. RdSAP mappers are unchanged (they keep the top-level required field; their SapHeating has no such attribute). Cert now maps + calculates (sap 76). Regression tests for the nested true/false fallback. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| epc | ||
| __init__.py | ||
| datatypes.py | ||
| enums.py | ||