mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
1a6996abbb
The legacy water_heating_efficiency(901, main_code) returns 0.80 (gas boiler default) when sap_main_heating_code is None — even if the main system is a heat pump (category=4, efficiency 2.30). For "from main system" water codes (901/902/914), we must inherit through the FULL main-heating cascade including the category fallback. Discovered by hand-tracing cert 0320-2850 (Semi-detached bungalow, heat-pump main with no SAP code lodged, actual SAP 70, predicted 49). HW was being charged at 0.80 eff for a 2.30-eff dwelling — 2.9× too much HW fuel. 100-cert parity probe: MAE 4.66 → 4.53 (-0.13) RMSE 6.27 → 5.96 bias -0.70 → -0.57 within ±10: 94% → 95% Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.