junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
Model/packages/domain
History
Khalim Conn-Kowlessar 20424a2dca Slice 21a: relabel ambient SAP 10.3 → SAP 10.2 in calculator docstrings 
The codebase targets SAP 10.2 (14-03-2025) per ADR-0010 and the values
match SAP 10.2 (grid CO2 = 0.136 not 0.086, ECF deflator = 0.42, etc.).
But ~35 docstrings/comments labelled formulas / sections / appendices
as "SAP 10.3 (13-01-2026)" — mis-labeling without affecting behaviour.

Relabels all of them to "SAP 10.2 specification (14-03-2025)" where the
formula being implemented is identical between 10.2 and 10.3 (which is
the vast majority — §1-§9 heat balance, §11/§13 SAP rating equations,
Appendix U climate tables, Table 9a/9c utilisation factor).

Intentionally retained:
- `worksheet/rating.py:14` — explicit comparison "SAP 10.3 widens these
  to 0.36 / 16.21 / 108.8 / 120.5" annotating where 10.3 values would
  differ from the 10.2 values we ship.
- `tables/table_12.py` — its docstring explicitly compares 10.2 vs 10.3
  CO2 / PEF differences; the file's purpose is the 10.2 → 10.3 reference
  table, so the 10.3 label is intentional discussion.

All 515 passing tests continue to pass (only the 48 known cascade-pin
failures from slice 19a remain — those are real residuals, not label
issues).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-22 23:05:55 +00:00
..
src/domain Slice 21a: relabel ambient SAP 10.3 → SAP 10.2 in calculator docstrings 2026-05-22 23:05:55 +00:00
pyproject.toml slice 13: to_rows(properties) returns pd.DataFrame 2026-05-16 16:43:28 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.