mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00

History

Khalim Conn-Kowlessar 2a9999bdf6 slice S-B22: primary energy in SapResult + Table 12 PEF column Wires SAP 10.2 Table 12 "Primary energy factor" column into Table 12 helpers and onto CalculatorInputs as three per-end-use factors (space heating, hot water, other). calculate_sap_from_inputs now emits primary_energy_kwh_per_yr and primary_energy_kwh_per_m2 on SapResult, matching the cert's `energy_consumption_current` field (PEUI). Triggered by a decomposition that revealed I'd been comparing our delivered energy to the cert's primary energy — apples to oranges. With proper primary-energy comparison the actual finding is: 300-cert primary-energy diff (cert calibration prices): energy MAE: 57.3 kWh/m² energy bias: +51.6 (we over-predict by ~50%) energy P50: +49.5 This is a much bigger systemic bug than the SAP MAE 5.34 suggested. Closing it requires investigating either (a) demand model over-prediction, (b) HW losses, (c) PEF values per fuel, or (d) cert reporting convention differences. Targeted for the next context. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>		2026-05-18 19:02:30 +00:00
..
src/domain	slice S-B22: primary energy in SapResult + Table 12 PEF column	2026-05-18 19:02:30 +00:00
pyproject.toml	slice 13: to_rows(properties) returns pd.DataFrame	2026-05-16 16:43:28 +00:00
README.md	added potential file scaffolding:	2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.