mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-08-03 05:18:22 +00:00
307fdfb270
Reviewer feedback: seasonal_efficiency_override_pct had no lodged-cert analogue and polluted the EpcPropertyData/MainHeatingDetail cert datatype. Replace it with the cert-native efficiency anchors a real cert already uses: - C–G -> sap_main_heating_code = the band's Table 4b code (combi/regular preserved by the code itself); resolved by the existing Table 4b path. - A/B -> main_heating_index_number = a type-matched representative PCDB product; resolved by the existing PCDB Appendix D2.1 path (winter+summer+combi-loss). _fold_heating clears the base code, so the effective cert reads as a real PCDB cert. Ready for future user-supplied product -> PCDB id. Deletes seasonal_efficiency_override_pct from MainHeatingDetail, HeatingOverlay and _MAIN_HEATING_FIELDS, and REVERTS both cert_to_inputs branches — those four files are now byte-identical to main (no synthesis on the cert type, no new calculator branch). Each A/B PCDB id is CI-guarded to its accredited (winter, summer) so a PCDB refresh fails loudly. Oil A-combi (no >90% product, ≈0 homes) keeps its code-130 default. Real certs: A-combi +2.06 SAP (idx 18964), D-regular -0.98 (code 106); corpus unmoved; 810 tests green (ADR-0068). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abri | ||
| applications | ||
| backend | ||
| condition | ||
| datatypes | ||
| domain | ||
| e2e | ||
| fixtures | ||
| harness | ||
| infrastructure | ||
| lambdas | ||
| magic_plan | ||
| orchestration | ||
| repositories | ||
| scripts | ||
| utilities | ||
| utils | ||
| __init__.py | ||
| conftest.py | ||
| test_lambda_packaging.py | ||