Model/packages/domain
Khalim Conn-Kowlessar 3aba735eee Cohort residual slice 16a: 000480 detailed RR + exposed-floor lodgement
Updates 000480's build_epc to lodge the §3 worksheet inputs that the
prior Simplified Type 1 fallback was approximating:

- Detailed §3.10 RR (7 surfaces on Main): 1 flat ceiling 2.31 + 2
  stud walls 4.24 + 2 slopes 10.78 — all uninsulated (Table 17 row
  "none" → U=2.30); plus 2 gable walls 11.33 / 8.47 routed to party
  at U=0.25 (Table 4 "as common wall"). Per [[feedback-no-
  misleading-insulation-type]] uninsulated surfaces leave
  insulation_type unset.

- roof_insulation_thickness=300 on Ext1 (Main has no storey-below
  external roof — the RR floor 19.83 m² covers the entire Main
  footprint 15.28 m²). Back-solves from U=0.14 / Table 16 row 300mm.

- is_exposed_floor=True on Ext1 floor=0 — 000480 line 207 lodges
  "Exposed floor Ext1 17.01 × U=1.20" (28b), routing via Table 20
  rather than the BS EN ISO 13370 ground-contact cascade. The Ext1
  sits over an unheated space (passageway / over-garage), not soil.

Impact: SAP integer 65 → 67 mid-slice (the Simplified Type 1 fallback
was over-estimating the RR shell; detailed lodgement + exposed-floor
corrects toward worksheet). The remaining +6 overshoot is the LINE_31
gable_wall overcount bug — closed in slice 16b alongside the new e2e
test pin and 000477 door_count revision.

No tests pinned for 000480 yet — the new e2e test_elmhurst_000480_
end_to_end_sap_score_matches_pdf lands in 16b once the calculator
fix closes Δ=0. Existing 409 tests stay green at this commit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-22 21:20:29 +00:00
..
src/domain Cohort residual slice 16a: 000480 detailed RR + exposed-floor lodgement 2026-05-22 21:20:29 +00:00
pyproject.toml slice 13: to_rows(properties) returns pd.DataFrame 2026-05-16 16:43:28 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.