mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
Closes 2 of 14 remaining diffs by populating Appendix J inputs the Elmhurst mapper surfaces from Summary §16: - `sap_heating.number_baths=1` (passed via make_sap_heating kwarg) - `sap_heating.shower_outlets = ShowerOutlets(Non-electric)` (set post-construction because the helper doesn't expose the field; added the dataclass imports for SCM completeness) Cascade-equivalent: number_baths=1 and one non-electric mixer outlet without WWHRS are the implicit Appendix J defaults when nothing is lodged. All 11 cohort 000474 cascade pins remain GREEN at 1e-4. Diff count: 14 → 12. Pyright net-zero (0 errors). Remaining 12 diffs split: - 7 mapper-needs-to-surface (country_code, water_heating_fuel, boiler_flue_type, emitter_temperature, main_heating_number, has_draught_lobby, central_heating_pump_age int↔str) - 3 party_wall_construction sentinel (None vs 0) across bps - 1 sap_windows: LEN 7 vs 5 (collapse vs 1:1 structural decision) - 1 dwelling_type / built_form casing nuance (resolved in Slice 64 bulk-update; remaining 1 was for one bp's encoding) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| domain | ||
| fetchers | ||
| repos | ||
| utils | ||
| README.md | ||
Shared packages
Workspace packages consumed by services/*. Each package is its own Python distribution with its own pyproject.toml; services import via the workspace dependency mechanism ({ workspace = true }).
| Package | Purpose |
|---|---|
domain/ |
Shared domain types — Property, BaselinePerformance, Plan, Scenario, EpcPropertyData, etc. No persistence, no IO, no business logic. |
repos/ |
Persistence layer — one repo per aggregate. Owns the SQL. Depends on domain. |
fetchers/ |
External API clients (gov EPC, Ofgem, Google Solar, etc.). Depend on domain for response shapes. |
utils/ |
Cross-cutting infra — logging, S3, CloudWatch URL builders, SQS task helpers. |
Adding a new shared package
Only when a real second consumer materialises. Don't pre-shatter (repos-epc, repos-property, ...) — split when a deployment needs to drop a dep, not before.
See ../ara_backend_design.md §11 for the broader monorepo layout and ../CONTEXT.md for the domain glossary that names the types living in domain/.