mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
4c0a907a54
Closes #1154 — the Package Scorer's Elmhurst cascade pin. Drives recommend_cavity_wall on the parsed `before` Summary, scores its Option's overlay through PackageScorer, and asserts delta 0 (abs<=1e-4 on SAP/CO2/PE) vs the calculator's score on the re-lodged `after` Summary. Key finding: the handover's stated parser gate (parse_site_notes_pdf throwing 'Manufacturer' on cert 001431) does NOT block these pins. The Elmhurst recommendation Summaries route cleanly through the same ElmhurstSiteNotesExtractor + EpcPropertyDataMapper chain the worksheet e2e fixtures use (_elmhurst_worksheet_001431.build_epc). The Textract path's window bug is unrelated and unused here. The before→after field change is exactly wall_insulation_type 4 (uninsulated) → 2 (filled cavity), which is precisely the overlay recommend_cavity_wall emits; the cascade closes at delta 0.000000 on all three metrics. Before/after Summaries mirrored into tests/domain/modelling/fixtures/ so the pin does not depend on the unstaged workspace. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| addresses | ||
| fuel_rates | ||
| modelling | ||
| property | ||
| property_baseline | ||
| sap10_calculator | ||
| tasks | ||
| __init__.py | ||
| test_building_geometry.py | ||
| test_postcode.py | ||