Model/packages/domain
Khalim Conn-Kowlessar 4df1ee78b7 slice 17b: SAP Appendix J port for predicted_hot_water_kwh (v2.2.0)
The 17a-baseline residuals showed cylinder_insulation_thickness_mm,
cylinder_size and cylinder_insulation_type at ranks 3/6/9 for hot_water_kwh
because the crude 16d formula didn't use them -- the model had to learn
storage physics from raw features.

Now predicted_hot_water_kwh sums:
  useful_demand   (existing, unchanged)
+ distribution_loss     = useful * 0.15
+ storage_loss          = volume * insulation_factor * 365 * 0.6
                          (volume from cylinder_size, factor from
                           cylinder_insulation_thickness_mm or age-default)
+ primary_circuit_loss  = 245 (age A-J) / 60 (age K-M)
- wwhrs_credit          = useful * 0.12  if number_baths_wwhrs > 0
- solar_hw_credit       = 250            if solar_water_heating
all / efficiency_water  = delivered kWh

Same inputs we already extract; just plumbed through. Expected:
predicted_hot_water_kwh feature usage jumps from rank 10 to top tier,
hot_water_kwh MAPE drops from 7.17%, and predicted_ecf gets tighter for
gas-heat + electric-DHW mid-band homes -> SAP MAPE marginally better.

5 new AAA tests; VERSION 2.1.0 -> 2.2.0 (MINOR; column semantics enriched).
2026-05-17 15:54:42 +00:00
..
src/domain slice 17b: SAP Appendix J port for predicted_hot_water_kwh (v2.2.0) 2026-05-17 15:54:42 +00:00
pyproject.toml slice 13: to_rows(properties) returns pd.DataFrame 2026-05-16 16:43:28 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.