mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
5324ae0e57
Resolve #1601 and land #1602/#1603 on the merged-#1609 tree, adjudicated against Khalim's verified ground truth (not pre_sap). #1601 (upper-floor +0.25 m joist void) — RESOLVED as keep-raw. The gov-API/Elmhurst mappers add 0.25 m to upper-storey heights because their lodged height is a clear internal ceiling. Against verified truth RAW beats +0.25 on all 7 verified dwellings (16 Stillwater raw -0.35 within-band vs +0.25 -0.75; every verified property is already under truth and +0.25 only lowers SAP). pashub surveys internal dimensions (202/205 "Measurements Location: Internal") and its upper-ground height gap is modal 0.00, so the joist void is not differentially present and a blanket +0.25 is unsafe. _map_floor_dimensions keeps the raw surveyed height with a RESOLVED note. #1602 — semi-exposed / exposed floor exposure. The surveyed "Floor type" "Semi Exposed (unheated)" now sets is_above_partially_heated_space (RdSAP §5.14 U=0.7) and "Exposed Floor" sets is_exposed_floor (§5.13 Table 20), on the lowest storey (floor==0) only, mirroring the gov-API/Elmhurst siblings. New strict-raise _pashub_floor_exposure (ADR-0015). #1603a — alternative walls. New AlternativeWall survey dataclass + extract_alternative_walls (the "Alternative Wall"->"Windows" section) + _map_pashub_alternative_walls -> sap_alternative_wall_1/2. The cascade deducts each alt-wall area from the part's main opaque wall (no double count), so a mixed-facade dwelling is billed at each sub-area's own construction. The alt-wall block lodges "As Built" (capital B) — aliased to the existing default insulation code. #1603b — extension floor construction. ExtensionConstruction gains a floor block (parsed like the main building) and _map_extension_building_part now threads floor_type/construction/insulation/u_value_known, which the main path already did and the extension silently dropped. Cohort: within-0.5 50.2% -> 51.2%, MAE 0.652 -> 0.624, 0 strict-raise errors across all 205. Verified-truth safe: none of the 7 verified dwellings have alt walls, and #1602 moves the one it touches (2 Philips exposed ext floor) by -0.00. pyright 0-new (mapper baseline 39). Goldens test_full_building_construction + end_to_end EXTENSION_1 updated. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| fixtures | ||
| __init__.py | ||
| test_elmhurst_end_to_end.py | ||
| test_elmhurst_extractor.py | ||
| test_end_to_end.py | ||
| test_extractor.py | ||
| test_heating_systems_corpus.py | ||
| test_pashub_sap_accuracy.py | ||
| test_pdf.py | ||
| test_room_heater_worksheet_001431.py | ||
| test_summary_pdf_mapper_chain.py | ||