Model/packages/domain
Khalim Conn-Kowlessar 5e34594d8a Cohort residual slice 18a: sap_heating lodgement on 000480 / 487 / 516
Wires PCDB main heating index + secondary heating type into the three
open fixtures. All three certs lodge:
- Vaillant ecoTEC PCDB index (000480=16839 pro 28, 000487=18119
  sustain 28, 000516=18118 sustain 24) at main_heating_data_source=1.
- Electricity Electric Panel/convector secondary (SAP code 691) at
  Table 11 fraction 0.10 (gas main + any secondary, page 188).
- number_baths (000480=0, 000487=1, 000516=1).

Confirmed against SAP 10.2 (14-03-2025) Table 11 page 188: "All gas,
liquid and solid fuel systems" main + "all secondary systems" →
fraction 0.10. PDF arithmetic on each fixture matches:
  000480: 12398.58 × 0.10 = 1239.86 kWh secondary ✓
  000487: 10834.78 × 0.10 = 1083.48 kWh secondary ✓
  000516: 12410.32 × 0.10 = 1241.03 kWh secondary ✓

Impact on continuous SAP delta (target <0.01):

  fixture | pre S18a | post S18a | status
  --------|----------|-----------|---------
  000480  |  +7.0885 |  +0.0012  | ✓ within 0.01
  000487  |  +5.5285 |  -1.9586  | over-corrected
  000516  |  +6.8375 |  +0.0349  | nearly closed (0.04)

000480 hits the 0.01 continuous gate — first time outside 000490.
000516 is within 0.04 (was +6.84). 000487 swung from +5.5 to -2.0,
suggesting the PCDB 18119 efficiency cascade diverges from what the
PDF assumes for that specific boiler — separate slice.

The previous fixture-lodgement gap was the dominant cost residual:
(242) secondary cost was £0 and (240) main heating was over-counting
because no PCDB efficiency was applied. Both close in this slice.
The remaining (251) standing charges (£120) gap is a calculator-side
issue addressed in the next slice (Table 12a page 191).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-22 22:10:24 +00:00
..
src/domain Cohort residual slice 18a: sap_heating lodgement on 000480 / 487 / 516 2026-05-22 22:10:24 +00:00
pyproject.toml slice 13: to_rows(properties) returns pd.DataFrame 2026-05-16 16:43:28 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.