mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
69668ec634
Unblocks two 38-cert-cohort certs that previously raised
`UnmappedElmhurstLabel("cylinder_size", 'Normal')` at extraction:
cert 2536-2525-0600-0788-2292 ws SAP=79.7264
cert 9421-3045-3205-1646-6200 ws SAP=87.4495
Both Summary §15.1 lodgements read "Cylinder Size: Normal"; both dr87
worksheets lodge line ref (47) "Store volume = 110.0000" L (extracted
from `Hot Water Cylinder → Cylinder Volume 110.00`). RdSAP 10 §10.5
Table 28 documents the "Normal (90-130 litres)" descriptor whose
midpoint is 110 L — the canonical Elmhurst label string in
`datatypes/epc/surveys/elmhurst_site_notes.py` is "Normal (90-130
litres)", and the worksheet's exact 110 L matches the midpoint.
Two-line fix:
+ "Normal": 2, in `_ELMHURST_CYLINDER_SIZE_LABEL_TO_SAP10`
+ 2: 110.0, in `_CYLINDER_SIZE_CODE_TO_LITRES`
The cascade enum 2 is consistent with the existing
`cert_to_inputs.py` docstring's documented (but not-yet-observed)
code 2 → Normal slot, alongside code 3 (Medium / 160 L) and code 4
(Large / 210 L) added in earlier slices.
Slice keeps tight: two mapping unit tests pinning `cylinder_size == 2`
for both certs at extraction. Post-fix the first-attempt cascade
deltas vs worksheet are:
cert 2536 Δ +0.0244 (was: RAISES)
cert 9421 Δ +0.0296 (was: RAISES)
Both deltas now sit in the same systematic +0.02..+0.07 small-gap
band as ~12 other first-attempt certs in cohort 2 — chain test +
±0.07 pin would just paper over a known systematic residual that the
user has explicitly asked to drive towards 1e-4, not toward ±0.07.
Following slice will investigate the shared systematic offset and
close cert 2536 / 9421 along with the rest of the +0.04 band on
the chain.
Pyright net-zero per file:
- datatypes/epc/domain/mapper.py: 32 (baseline 32)
- domain/sap10_calculator/rdsap/cert_to_inputs.py: 35 (baseline 35)
- backend/documents_parser/tests/test_summary_pdf_mapper_chain.py: 0
Regression baseline: 691 pass + 10 fail (= prior 689 + 10 + 2 new GREEN).
Spec refs:
- RdSAP 10 §10.5 Table 28 — "Cylinder Volume" Normal band 90-130 L,
midpoint 110 L (also the canonical Elmhurst label suffix).
- Cert 2536 worksheet `dr87-0001-000889.pdf` line ref (47) = 110.0000.
- Cert 9421 worksheet `dr87-0001-000884.pdf` line ref (47) = 110.0000.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| elmhurst_site_notes_1_text.json | ||
| elmhurst_site_notes_2_text.json | ||
| ElmhurstSiteNotes.pdf | ||
| ElmhurstSiteNotes_2.pdf | ||
| pashub_site_notes_1_text.json | ||
| pashub_site_notes_2_text.json | ||
| pashub_site_notes_3_text.json | ||
| pashub_site_notes_4_text.json | ||
| pashub_site_notes_5_text.json | ||
| pashub_site_notes_6_text.json | ||
| pashub_site_notes_7_text.json | ||
| PasHubSiteNotes_1.pdf | ||
| PasHubSiteNotes_2.pdf | ||
| PasHubSiteNotes_3.pdf | ||
| PasHubSiteNotes_4.pdf | ||
| PasHubSiteNotes_5.pdf | ||
| PasHubSiteNotes_6.pdf | ||
| PasHubSiteNotes_7.pdf | ||
| Summary_000474.pdf | ||
| Summary_000477.pdf | ||
| Summary_000480.pdf | ||
| Summary_000487.pdf | ||
| Summary_000490.pdf | ||
| Summary_000516.pdf | ||
| Summary_000784.pdf | ||
| Summary_000884.pdf | ||
| Summary_000889.pdf | ||
| Summary_000897.pdf | ||
| Summary_000898.pdf | ||
| Summary_000899.pdf | ||
| Summary_000900.pdf | ||
| Summary_000901.pdf | ||
| Summary_000902.pdf | ||
| Summary_000903.pdf | ||
| Summary_000904.pdf | ||
| Summary_001479.pdf | ||