mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00

History

Khalim Conn-Kowlessar 696d43112e fix: translate gov EPC API fuel codes to SAP10.2 Table 32 (v2.3.0) predicted_total_fuel_cost_gbp was silently mispricing every non-gas property because primary_main_fuel_type / water_heating_fuel store the gov EPC API enum (26=mains gas, 27=LPG, 28=oil, 29=electricity) and our _FUEL_UNIT_PRICE dict is keyed by Table 32 codes (1=gas, 4=oil, 30=elec). Codes 26-29 hit the dict's default 3.48 p/kWh -- silently treating electric immersion as gas. Concrete impact on OX1 5LR Sep 2025 cert (worst-predicted SAP=41, model 84): water_heating_fuel=29 (electric immersion). Real DHW cost 2941 kWh * 13.19p = £388/yr; we computed 2941 * 3.48 = £102 (4x under). Net predicted_total_fuel_cost £292 vs implied real £2513 -- predicted_ecf 0.49 (~SAP 93) vs real ECF 4.24 (SAP 41). Effect: every off-gas property's predicted_ecf was systematically too low, dragging the model's catastrophic-low-SAP predictions toward mid-band. Expected to substantially reduce decile-0 bias on retrain. New _API_TO_TABLE32 map covers codes 0-29. 4 new AAA tests; VERSION 2.2.0 -> 2.3.0 (MINOR; behavioural fix to existing column values).		2026-05-17 17:02:21 +00:00
..
src/domain	fix: translate gov EPC API fuel codes to SAP10.2 Table 32 (v2.3.0)	2026-05-17 17:02:21 +00:00
pyproject.toml	slice 13: to_rows(properties) returns pd.DataFrame	2026-05-16 16:43:28 +00:00
README.md	added potential file scaffolding:	2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.