mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
035d916dd6
Closes the final 49 → 0 diffs in two moves:
1. **Filter non-load-bearing SapWindow sub-fields from the diff.** The
Elmhurst mapper surfaces Summary §11 strings (window_type='Window',
glazing_type='Double between 2002 and 2021', glazing_gap='12 mm',
data_source='Manufacturer', permanent_shutters_present='None')
while the cohort `make_window` helper produces API-style int codes
for the same fields. None of these affect the SAP cascade — it
reads only window_width / window_height / orientation /
window_location / frame_factor / window_transmission_details.
{u_value, solar_transmittance}. Adding `_NON_LOAD_BEARING_WINDOW_
SUBFIELDS` + `_is_excluded_path` to the diff helper drops them
from the comparison without changing the load-bearing scope. Per
the user's earlier "load-bearing only" decision — encoding noise
that doesn't change the cascade output is excluded.
2. **`make_window` helper now defaults `frame_factor=0.7`.** The
SAP10.2 Table 6c PVC default (and the modal value the Elmhurst
mapper surfaces from Summary §11). Previously the helper left it
`None`, which the cascade resolves to 0.7 internally; setting it
explicitly is cascade-equivalent and closes the last 7 diffs.
Diff count for cohort 000474:
Slice 63 baseline: 50
Slice 64 (Cat A): 14
Slice 65 (HW): 12
Slice 66+67 (mapper): 5
Slice 68 (party-wall): 1
Slice 69 (windows): 49 (encoding-noise surface)
Slice 70 (filter): **0** — diff test now GREEN
`test_from_elmhurst_site_notes_matches_hand_built_000474` PASSES.
First cohort cert fully validated at the EpcPropertyData load-
bearing-field level. All 66 cohort cascade pins remain GREEN at
1e-4. Pyright net-zero (0 errors on touched files).
Next slices: parametrize the diff test over the 5 other cohort
certs (000477, 000480, 000487, 000490, 000516) — each may have
its own bulk-update + mapper-tweak pattern, but the toolchain
(diff helper, exclusion list, _LOAD_BEARING_FIELDS, helper
defaults) is in place. Then 001479 (after Slice 62 hand-built
hits 1e-4). Then the API mapper diff test (currently the API
mapper has its own gaps — Slice 58/59/60 cascade fixes closed
golden cert residuals but field-level cross-mapper parity isn't
asserted yet).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.