mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
`_map_sap_heating` left `main_heating_index_number` None, so the calculator fell to a generic Table-4b seasonal efficiency instead of the actual appliance. The site note lodges the boiler by its PCDB `product_id` (and `summer_efficiency` is always 0), and those ids resolve directly in the calculator's PCDB (`gas_oil_boiler_record`) — so carrying `product_id` onto `main_heating_index_number` gives the real SEDBUK efficiency. Gated on `product_id > 0` (0 = no product lodged → stays None; the calculator keeps its default). `main_heating_category`/`sap_main_heating_code` were evaluated and add nothing measurable — the PCDB index alone is the efficiency source. Guinness GMCA cohort: within-0.5 12.9% -> 13.4%, MAE 2.657 -> 2.621, no regression (harness still 206-xfail, no new hard failures). Closes #1563 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| epc | ||
| __init__.py | ||
| address_match.py | ||
| datatypes.py | ||
| enums.py | ||