junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
Model/packages
History
Khalim Conn-Kowlessar 6be8fdb7b6 Slice 22: per-window curtain resistance — fixes mixed-glazing window U 
SAP 10.2 §3.2 applies the 0.04 m²K/W curtain resistance per window;
the worksheet's (27) column shows it that way. Our calc had been
applying it ONCE to the area-weighted-avg raw U across all windows.
That's correct when all windows share a U but biased when a dwelling
has mixed glazing types (typical Elmhurst fixture lodges 2 types):

  U_eff(weighted_avg(U_i)) ≠ weighted_avg(U_eff(U_i))

because 1/(1/U + 0.04) is non-linear. The drift was ~0.05-0.10 W/K
on `windows_w_per_k` for 000474, 000477, 000487 (mixed-glazing
fixtures).

Fix: when sap_windows have per-window u_value lodged (the spec-
faithful path), iterate them computing per-window U_eff × area and
sum. Falls back to the legacy single-avg-U path when window U isn't
lodged (back-compat for synthetic tests that pass
`window_avg_u_value=...` directly).

Per-window LINE_27 numbers now match PDF exactly:

  fixture | windows W/K calc → PDF | LINE_33 Δ before → after
  --------|------------------------|---------------------------
  000474  | 25.4243 → 25.3674 ✓    |   +0.0864 → +0.0296  (-66%)
  000477  | 17.8550 → 17.8349 ✓    |   -0.1045 → -0.1246  (small
                                       widening — exposes
                                       upstream floor-U drift)
  000487  | (cascading)            |   +37.88 (RR defect, slice 23)
  000480  | unchanged              |   -0.0168 → -0.0168  (single U)
  000490  | unchanged              |   +0.0282 → +0.0282  (single U)
  000516  | (cascading)            |   -6.75 (RR defect, slice 23)

Total cascade pin failure count unchanged at 83 (pins still above
abs=1e-4 floor by 0.03-0.13 W/K — sub-display-precision drift left
in floor-U cascades + the two RR fixture defects).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-22 23:33:23 +00:00
..
domain Slice 22: per-window curtain resistance — fixes mixed-glazing window U 2026-05-22 23:33:23 +00:00
fetchers added potential file scaffolding: 2026-05-15 10:56:53 +00:00
repos added potential file scaffolding: 2026-05-15 10:56:53 +00:00
utils added potential file scaffolding: 2026-05-15 10:56:53 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

README.md

Shared packages

Workspace packages consumed by services/*. Each package is its own Python distribution with its own pyproject.toml; services import via the workspace dependency mechanism ({ workspace = true }).

Package Purpose
domain/ Shared domain types — Property, BaselinePerformance, Plan, Scenario, EpcPropertyData, etc. No persistence, no IO, no business logic.
repos/ Persistence layer — one repo per aggregate. Owns the SQL. Depends on domain.
fetchers/ External API clients (gov EPC, Ofgem, Google Solar, etc.). Depend on domain for response shapes.
utils/ Cross-cutting infra — logging, S3, CloudWatch URL builders, SQS task helpers.

Adding a new shared package

Only when a real second consumer materialises. Don't pre-shatter (repos-epc, repos-property, ...) — split when a deployment needs to drop a dep, not before.

See ../ara_backend_design.md §11 for the broader monorepo layout and ../CONTEXT.md for the domain glossary that names the types living in domain/.