mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
6bfb0614aa
Replaces the loose collection of fixture-specific SAP score tests + parametrized lighting / pumps_fans / secondary spot-checks with a single strict cascade pin: every SapResult float field vs PDF line ref at abs=1e-4, every fixture × field pair as its own parametrized case. 66 cases (11 fields × 6 fixtures); 18 pass, 48 fail. Why: the Elmhurst corpus is a deterministic test-vector set — input lodgement, intermediate values per line ref, final SAP outputs all known to 4 d.p. To replicate SAP 10.2 exactly there is no reason to accept tolerance >0 on the final outputs. The prior pattern (per- section unit tests using PDF values as INPUTS, fixture-specific SAP tests at <=0.5 continuous, fuel-cost tests at rel=0.05 / rel=0.15) let cascade biases propagate without surfacing as named failures. Pin matrix: field | 474 | 477 | 480 | 487 | 490 | 516 -----------------------------------|-----|-----|-----|-----|-----|----- sap_score (int) | ✓ | ✓ | ✓ | ✗ | ✓ | ✓ sap_score_continuous | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ ecf | ✗ | ✗ | ✓ | ✗ | ✗ | ✗ total_fuel_cost_gbp | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ co2_kg_per_yr | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ space_heating_kwh_per_yr | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ main_heating_fuel_kwh_per_yr | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ secondary_heating_fuel_kwh_per_yr | ✓ | ✗ | ✗ | ✗ | ✗ | ✗ hot_water_kwh_per_yr | ✗ | ✗ | ✗ | ✗ | ✗ | ✗ lighting_kwh_per_yr | ✓ | ✓ | ✓ | ✓ | ✓ | ✗ pumps_fans_kwh_per_yr | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ Each failing test name is the work queue. No tolerance widening, no xfail — a failing pin is a named calculator bug. Subsequent slices close them one at a time. Existing loose-tolerance tests in test_fuel_cost.py (rel=0.15 for 000474 and rel=0.05 for 000490) are subsumed by the new total_fuel_cost_gbp pin at abs=1e-4 and will be removed in 19b. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.