mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
960419a901
Lodges the missing cert fields on 000477 build_epc to match U985 PDF: - sap_windows = SECTION_6_VERTICAL_WINDOWS (was empty) - low_energy_fixed_lighting_bulbs_count = 9 (was None) - sap_heating.main_heating_details with PCDF index 18118 (was default) - sap_heating.secondary_heating_type = 691 (was None) - sap_heating.number_baths = 0 (PDF lodges 0 baths; was None → defaulted to "has bath"=True) `make_sap_heating` accepts a new `number_baths` kwarg to surface that field — it lives on SapHeating but wasn't exposed before. Impact: 000477 SAP integer 71 → 66 (PDF 65, Δ +6 → +1); cost £599 → £707 vs PDF £732 (Δ -22% → -3.5%); useful 9059 → 10067 vs PDF 10111 (matches to <0.5%). Remaining +1 SAP integer delta is the **Table 3c two-profile combi- loss override** — not yet implemented. PCDB 18118 (Vaillant ecoTEC sustain 24) lodges separate_dhw_tests=2 → spec Appendix J §J3 uses both Profile M (F1, R1) and Profile L (F2, R2) loss factors. Our override gate (`_pcdb_table_3b_combi_loss_override`) only accepts separate_dhw_tests==1 → falls back to Table 3a keep-hot time-clock 600 kWh/yr default = 25x overshoot vs the fixture-pinned ~24 kWh/yr. The same gap blocks 000480 (PCDB 16839 — but actually wait, 16839 is in 000490 too and that already closes — needs checking), 000487 (PCDB 18119), and 000516 (PCDB 18118). Test pin `test_elmhurst_000477_end_to_end_sap_score_matches_pdf` xfail (strict) with rationale pointing at Table 3c. Re-enables when the override implements. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.