mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
Dan's review on #1546: - Stream the workbook to a /tmp temp file and S3Client.upload_file it, instead of render_workbook -> bytes -> put_object. render_workbook now saves straight to a path; the orchestrator renders to a temp file, multipart-uploads it, and always cleans it up. Restores ADR-0065's "never an in-memory BytesIO" decision (the OOM path at the 100k-row cap). - Move the raw `SELECT ... FROM scenario` out of the Lambda handler into ScenarioNamesPostgresRepository, so the handler stays composition-only and all SQL lives in repositories/. - current_sap_points goes through _float, matching its Optional[float] read-model type and the sibling numeric facts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abri | ||
| chatgpt | ||
| epc_client | ||
| magic_plan | ||
| postcodes_io | ||
| postgres | ||
| solar | ||
| xlsx | ||
| __init__.py | ||
| conftest.py | ||
| test_address2uprn_queue_client.py | ||
| test_csv_s3_client.py | ||
| test_gzip_csv_s3_client.py | ||
| test_http_retry.py | ||
| test_s3_client.py | ||
| test_s3_document_downloader.py | ||
| test_s3_uri.py | ||
| test_sqs_client.py | ||