mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
a5d889e143
Two unrelated breakages surfaced after merging the PR into this branch; neither was caused by the appliances/cooking work. test_appendix_u.py (9 failures) — signature drift + wrong methodology label. The climate lookups were renamed `external_temperature_c(region=…)` → `(region_or_climate, month)` when PostcodeClimate support landed for the demand cascade, but the tests still passed `region=`. The expected values match our SAP 10.2 _TABLE_U1/U2/U3 exactly (UK-avg Jan 4.3 °C, Thames Jul 17.9 °C, solar Jul 189 W/m², Shetland Jan wind 9.5 m/s), so these are valid 10.2 coverage — fixed the call signature to positional and corrected the mislabelled "SAP 10.3" docstrings to SAP 10.2 (we track 10.2 deliberately). Also converted pytest.approx → abs(x-y)<=tol per the repo convention; pyright on the file drops 48 → 0. test_table_32.py (2 failures) — the parametrised "match PDF p.95" test pinned heating oil (code 4) = 7.64 and FAME (code 73) = 5.44, but the table deliberately diverges from the PDF for these two carriers: oil = 5.44 (Slice S0380.131, two independent lodging engines agree the PDF 7.64 is the outlier) and FAME = 7.64 (Slice S0380.168). Updated the two expected values to the worksheet-canonical figures the table actually uses, with inline citations + a docstring note on the divergence. Full calculator + property_baseline + heating-corpus suites: 1748 pass, 0 fail. pyright net-improving on both files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| addresses | ||
| data_transformation | ||
| epc | ||
| fuel_rates | ||
| geospatial | ||
| property | ||
| property_baseline | ||
| sap10_calculator | ||
| sap10_ml | ||
| tasks | ||
| postcode.py | ||