mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
94275d07cc
RdSAP 10 §10.5 (PDF p.55): "If the actual size is not determined, the size of a hot-water cylinder is taken as according to Table 28." When a cylinder is present (has_hot_water_cylinder) but no size descriptor resolves — the gov API lodges cylinder_size=0, or Exact with no measured volume — `_hot_water_ cylinder_volume_l` returned None, silently dropping BOTH the cylinder's storage loss and the Table 13 electric-DHW high-rate fraction, under-costing and over-rating the dwelling. Default such cylinders to the Table 28 baseline "Normal" 110 L (the value §10.7 also instantiates as the first-row default). The context-dependent Inaccessible 210/160 values are deliberately NOT applied here — they are tied to the explicit "Inaccessible" descriptor (code 5) the assessor lodges, not to an unpopulated size field. Scope: 7 of 301 cylinder certs in the corpus (2%). Correctness fix — closes a real spec gap; marginal on the headline (within-0.5 66.1% unchanged, MAE 1.128 -> 1.124) because these certs' residual is dominated by a separate HW- demand gap, not the cylinder. Worksheet harness 47/47 0 diverge (Summary certs lodge a real size, so the fallback never fires). 1 AAA test, pyright net-zero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| addresses | ||
| billing | ||
| fuel_rates | ||
| magicplan | ||
| modelling | ||
| property | ||
| property_baseline | ||
| sap10_calculator | ||
| tasks | ||
| __init__.py | ||
| test_building_geometry.py | ||
| test_postcode.py | ||