mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00

History

Khalim Conn-Kowlessar 9a509e4102 slice S-B23: RdSAP 10 Table 6 "Filled cavity" row dispatch The cert encodes filled-cavity walls as (wall_construction=4 cavity, wall_insulation_type=2 filled, wall_insulation_thickness="NI"). The previous cascade parsed "NI"→0 and ran the thickness-bucketed table, returning U=1.5 (the "Cavity as built" row) — treating retrofit-filled cavities as if they were uninsulated. Spec (RdSAP 10 Table 6, page 33) has a dedicated "Filled cavity" row at U=0.7 for bands A-E, 0.40 at F, 0.35 at G-H, and "as built" from band I onward. Adds: - WALL_INSULATION_FILLED_CAVITY constant (code 2 per RdSAP schema, confirmed empirically on 8 000 corpus certs against walls.description) - _CAVITY_FILLED_ENG row in domain.ml.rdsap_uvalues - dispatcher in u_wall when (construction=cavity, insulation_type=2) - wall_insulation_type plumbing through heat_transmission_from_cert Parity probe (300 certs, seed=7) before → after: - PE MAE 57.28 → 48.99 (-8.3) - PE bias 51.56 → 42.07 (-9.5) - Band C bias +65.3 → +47.8 (-17.5) - Band D bias +67.9 → +45.7 (-22.2) - Band E bias +77.0 → +58.8 (-18.2) - Band F bias +43.8 → +25.4 (-18.4) - Band K-L bias unchanged (filled-cavity row falls back to as-built from band I onward per spec footnote; correct no-op) Future slices already lit up by the same enumeration: - type=1 external / type=3 internal insulation rows (~440 certs) - type=6 filled + external / type=7 filled + internal (~22 certs) - type=None "Average thermal transmittance X W/m²K" string parse (1 358 certs — biggest follow-up) Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>		2026-05-18 20:15:41 +00:00
..
src/domain	slice S-B23: RdSAP 10 Table 6 "Filled cavity" row dispatch	2026-05-18 20:15:41 +00:00
pyproject.toml	slice 13: to_rows(properties) returns pd.DataFrame	2026-05-16 16:43:28 +00:00
README.md	added potential file scaffolding:	2026-05-15 10:56:53 +00:00

README.md

domna-domain

Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.

Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.

Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.

Layout

src/domain/
├── __init__.py
├── property.py             # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py                 # Plan, PlanPhase, OptimisedPackage
├── scenario.py             # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
    ├── __init__.py
    ├── transform.py        # EpcMlTransform (versioned per §8.3)
    └── schema.py

When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.