Model/packages
Khalim Conn-Kowlessar 9cb79d9c98 Slice 26: §5 internal gains cascade pin (50/54 PASS) + rooflight daylight plumb
Added `internal_gains_section_from_cert` helper composing §1 (volume) +
§4 (heat_gains line 65)m → §5 orchestrator, and 54 strict pin cases for
worksheet lines (66)..(73) monthly + (232) annual lighting kWh.

Also fixed a missing input plumb: cert_to_inputs was passing
`rooflight_total_area_m2=0` to `internal_gains_from_cert`, so the
000516 roof window (lodged on `epc.sap_roof_windows` since slice 24)
wasn't contributing to the L2a daylight factor. Added
`_rooflight_total_area_m2_from_cert` and routed it through both the
public cert→inputs cascade and the new §5 section helper.

§5 cascade:
  field    | 474 | 477 | 480 | 487 | 490 | 516
  LINE_66  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓
  LINE_67  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  (rooflight plumb)
  LINE_68  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓
  LINE_69  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓
  LINE_70  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓
  LINE_71  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓
  LINE_72  |  ✓  |  ✗  |  ✓  |  ✗  |  ✓  |  ✓
  LINE_73  |  ✓  |  ✗  |  ✓  |  ✗  |  ✓  |  ✓
  LINE_232 |  ✓  |  ✓  |  ✓  |  ✓  |  ✓  |  ✓

Remaining failures are 000477 + 000487 LINE_72/73 — cascaded from §4
LINE_65 heat_gains residuals (000477 combi loss, 000487 HW lodgement
defect). Both fixtures are slice 25 territory.

Scoreboard:
  section_cascade_pins: 170 → 220 PASS (+50; 54 new tests, 4 fail)
  e2e SapResult:        29 →  30 PASS (+1, downstream from rooflight plumb)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-23 21:21:32 +00:00
..
domain Slice 26: §5 internal gains cascade pin (50/54 PASS) + rooflight daylight plumb 2026-05-23 21:21:32 +00:00
fetchers added potential file scaffolding: 2026-05-15 10:56:53 +00:00
repos added potential file scaffolding: 2026-05-15 10:56:53 +00:00
utils added potential file scaffolding: 2026-05-15 10:56:53 +00:00
README.md added potential file scaffolding: 2026-05-15 10:56:53 +00:00

Shared packages

Workspace packages consumed by services/*. Each package is its own Python distribution with its own pyproject.toml; services import via the workspace dependency mechanism ({ workspace = true }).

Package Purpose
domain/ Shared domain types — Property, BaselinePerformance, Plan, Scenario, EpcPropertyData, etc. No persistence, no IO, no business logic.
repos/ Persistence layer — one repo per aggregate. Owns the SQL. Depends on domain.
fetchers/ External API clients (gov EPC, Ofgem, Google Solar, etc.). Depend on domain for response shapes.
utils/ Cross-cutting infra — logging, S3, CloudWatch URL builders, SQS task helpers.

Adding a new shared package

Only when a real second consumer materialises. Don't pre-shatter (repos-epc, repos-property, ...) — split when a deployment needs to drop a dep, not before.

See ../ara_backend_design.md §11 for the broader monorepo layout and ../CONTEXT.md for the domain glossary that names the types living in domain/.