mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
a21d2cc579
Closes #1684. `_main_2_space_heating_fuel_cost_gbp_per_kwh` billed an electric Main 2 at Main 1's space-heating rate. That was a no-op on a homogeneous off-peak cohort (storage+storage, direct+direct → equal rates) but mis-billed the HETEROGENEOUS case: an off-peak STORAGE Main 1 (5.5 p/kWh low) + an on-peak DIRECT-ACTING panel Main 2 (15.29 p/kWh high) rode the storage low rate, under-costing the panel half and over-rating SAP. Flip it to bill Main 2 at its OWN Table 12a Grid 1 SH row, the same per-system resolution Main 1 and a non-electric Main 2 already use — and the same one `_main_2_high_rate_fraction` already applies, so the scalar cost and the high-rate split are now consistent. The docstring's "regresses certs 13/34 (Parkers Hill / Dunley Road)" warning was stale: those names appear nowhere but that docstring, and the full guard suite shows zero new regressions (only the two pre-existing `test_heating_systems_corpus` fails on main). LRHA WAVE 3 fixture 497655371974 (storage+panel) moves +15.3 → -2.5 vs PasHub; cohort MAE 0.799 → 0.675 (ratchet re-baselined 0.80 → 0.68). within-0.5 holds at 55.3% — the -2.5 residual is PasHub-vs-Elmhurst divergence, not a bug, so the fixture stays out of the within-0.5 pin. A ground-truth Elmhurst pin is queued (see docs/HANDOVER_1684_ELMHURST_INPUTS_497655371974.md). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abri | ||
| addresses | ||
| billing | ||
| bulk_document_download | ||
| data_transformation | ||
| elmhurst | ||
| epc | ||
| epc_prediction | ||
| fuel_rates | ||
| geospatial | ||
| magicplan | ||
| modelling | ||
| pashub_fetcher | ||
| property | ||
| property_baseline | ||
| sap10_calculator | ||
| sap10_ml | ||
| scenario_export | ||
| tasks | ||
| building_geometry.py | ||
| postcode.py | ||