Khalim Conn-Kowlessar b55b969b84 fix(water-heating): use lodged cylinder_heat_loss declared-loss factor ... The gov API lodges a manufacturer's declared cylinder loss factor (kWh/day) in `sap_heating.cylinder_heat_loss`, in which case it leaves the cylinder volume / insulation type / thickness None. That field was undeclared on the 21.0.x schemas, so `from_dict` dropped it — then `_cylinder_storage_loss_override` hit its insulation-None / volume-None guards and returned None, dropping the §4 storage loss ENTIRELY. The dwelling over-rated (the declared loss is typically ~1.5 kWh/day ≈ 550 kWh/yr). SAP 10.2 §4 branch a) (PDF p.136): when the declared loss factor is known, storage loss (50) = (48) declared loss × (49) Table-2b temperature factor — replacing the Table 2 V×L×VF computation. - declare `cylinder_heat_loss` on RdSapSchema21_0_0/21_0_1.SapHeating + EpcPropertyData.SapHeating; thread through the 21.0.x mappers. - `cylinder_storage_loss_monthly_kwh` gains `declared_loss_kwh_per_day`: when set, combined_55 = declared × TF (volume/insulation unused). - `_cylinder_storage_loss_override` resolves the declared loss BEFORE the insulation/volume guards (the gov omits those when the loss is lodged). 12 /tmp certs carry it (mean |err| 3.00 -> 2.51; the clean ones close hard, e.g. 2360 2.65 -> 0.30, 0245 2.25 -> 0.53). Corpus within-0.5 67.0% -> 67.3% (MAE 1.025 -> 1.020); /tmp 71.2% -> 71.4% (0.889 -> 0.882). Worksheet harness 47/47; regression = only the 3 pre-existing fails; pyright net-zero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>		2026-06-16 05:27:47 +00:00
..
tests	fix(water-heating): use lodged cylinder_heat_loss declared-loss factor	2026-06-16 05:27:47 +00:00
__init__.py	fix broken imports and rename mapper class	2026-04-13 16:36:13 +00:00
epc.py	feat(modelling): Epc.sap_lower_bound() — band → minimum SAP (#1160)	2026-06-03 12:50:40 +00:00
epc_codes.csv	slice 8a: window physics and orientation aggregates	2026-05-16 15:32:45 +00:00
epc_property_data.py	fix(water-heating): use lodged cylinder_heat_loss declared-loss factor	2026-06-16 05:27:47 +00:00
field_mappings.py	insulation thickness can be string 🟥	2026-04-15 14:26:09 +00:00
historic_epc.py	demo generated for use in address2uprn	2026-05-08 14:48:15 +00:00
historic_epc_matching.py	rank address similiarity	2026-05-12 16:02:01 +00:00
mapper.py	fix(water-heating): use lodged cylinder_heat_loss declared-loss factor	2026-06-16 05:27:47 +00:00