mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
e91e0fa33e
Both flagged mismatches were Elmhurst input errors (same silent-stale-value
contamination class as the earlier chimneys/wall-thickness bugs), not
parser or calculator bugs:
- cylinder_size: build_100010086084.py's water_heating() selected
DropDownListCylinderSize by raw value "2", but this DOM's option values
ARE their visible litre-band text (no "2" among them) — Playwright
silently no-ops on a non-matching value, leaving a prior cert's "Medium
(131-170L)" selection in place. Fixed to match by text ("Normal"), and
added the missing mapper dict entries (Normal/Large litre-suffixed
labels) to _ELMHURST_CYLINDER_SIZE_LABEL_TO_SAP10 (a real mapper-coverage
gap — the calculator raises UnmappedElmhurstLabel rather than silently
mis-mapping).
- boiler_flue_type: the boiler-code search dialog's combined "Balanced/Open
Flue" Table 4b category doesn't drive the separate, independently
selectable RadioButtonListFlueType field, which was left at an inherited
"Balanced" from a prior cert. Fixed space_heating() to explicitly select
"Open" to match the lodged gov-API code. This field isn't consumed by
Sap10Calculator (ML/generator-only), so it had zero effect on the SAP
score.
Re-downloaded elmhurst_summary.pdf/elmhurst_worksheet.pdf after the fixes
(Recommendations page confirmed clean). Elmhurst-PDF-inputs path moved
46->47 SAP from the cylinder-volume correction; gov-API SAP (53) and
Elmhurst's own worksheet (51) are unchanged. Full accuracy suites re-run
clean (67 passed, 67 skipped, 1 xfailed, same as before).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| CEPC-7.0 | ||
| CEPC-7.1 | ||
| CEPC-8.0.0 | ||
| RdSAP-Schema-17.0 | ||
| RdSAP-Schema-17.1 | ||
| RdSAP-Schema-18.0 | ||
| RdSAP-Schema-19.0 | ||
| RdSAP-Schema-20.0.0 | ||
| RdSAP-Schema-21.0.0 | ||
| RdSAP-Schema-21.0.1 | ||
| real_life_examples | ||
| SAP-Schema-16.0 | ||
| SAP-Schema-16.1 | ||
| SAP-Schema-16.2 | ||
| SAP-Schema-16.3 | ||
| SAP-Schema-17.0 | ||
| SAP-Schema-17.1 | ||
| SAP-Schema-18.0.0 | ||
| SAP-Schema-19.0.0 | ||
| SAP-Schema-19.1.0 | ||
| SAP-Schema-19.2.0 | ||