mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
c11eb46b8a
The HHR-storage HeatingOverlay (ADR-0024) added an off-peak electric immersion cylinder but never set `immersion_heating_type`, so the overlaid cert left it None. The calculator then could not resolve `immersion_single` for the SAP 10.2 Table 13 HW high-rate split and billed hot water 100% at the off-peak low rate — £127.41 vs the relodged after-cert's £169.39, overstating the overlay's SAP by +1.26 (CO2/PE matched, isolating it to the HW cost path). Add `immersion_heating_type` to HeatingOverlay, route it through `_fold_heating` (it lives on `sap_heating`), and set it to 1 (single off-peak immersion) on the HHR overlay to match the relodged reference. Closes both `test_hhr_storage_overlay_reproduces_the_relodged_after_*` cascade pins (electric-storage and no-system befores share the after). Pre-existing failure (present before this branch's recent commits), outside the handover regression gate. Full modelling suite 220 pass, pyright net- zero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| floor_recommendation.py | ||
| glazing_recommendation.py | ||
| heating_recommendation.py | ||
| lighting_recommendation.py | ||
| roof_recommendation.py | ||
| secondary_heating_recommendation.py | ||
| solar_recommendation.py | ||
| solid_wall_recommendation.py | ||
| ventilation_recommendation.py | ||
| wall_recommendation.py | ||