mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
The prior commit derived a Python bool (`cylinder_size != 1`), but `from_rdsap_schema_17_1` reads the field via `schema.has_hot_water_cylinder == "true"` — every real 15.0/16.x fixture lodges the lowercase string "true"/"false", not a JSON boolean. A bare bool compares False against that string check either way, so the derivation silently mapped every cylinder-present cert to has_hot_water_cylinder=False too. Caught by the requested true-branch test (mutating sap_16_2.json, which lodges cylinder_size=2/has_hot_water_cylinder="true", to omit the field) — it failed under the original bool-typed fix. Now emits "true"/"false" strings to match the lodged convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| domain | ||
| loaders | ||
| schema | ||
| search | ||
| surveys | ||
| __init__.py | ||
| construction_age_band.py | ||
| efficiency.py | ||
| floor.py | ||
| fuel.py | ||
| heating_controls.py | ||
| hotwater.py | ||
| main_heating.py | ||
| property_type_built_form.py | ||
| roof.py | ||
| walls.py | ||
| windows.py | ||