mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
adb1bf4b56
/health already returned GITHUB_SHA in its response but never logged it, and the fastapi lambda's Terraform environment never actually set GITHUB_SHA — so every health check response contained "unknown" in production. Wire var.github_sha through the fastapi lambda module (default "unknown" for local/other invocations) via a new TF_VAR_github_sha env var set from `github.sha` in _deploy_lambda.yml's Terraform Plan step, and log it on every /health call so a request in CloudWatch can be tied back to the deploy that served it. Also fix the zip-size gate added for PR #1469: putting it in tests/test_lambda_zip_size.py (run via the Docker-based ddd_tests.yml suite) broke CI, because Dockerfile.test's build context excludes deployment/* (.dockerignore), so check_lambda_zip_size.py couldn't find variables.tf to read zip_excludes from inside that container. Move the check to its own lightweight workflow, check_lambda_zip_size.yml, triggered on pull_request into main — a plain checkout (no Docker build) has the full repo, so the check works, runs fast, and still gates merges to main before a regression can roll into the dev deploy. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
72 lines
2.5 KiB
Python
72 lines
2.5 KiB
Python
import logging
|
|
import os
|
|
from fastapi.responses import JSONResponse
|
|
from fastapi import FastAPI, Depends, Request, status
|
|
from fastapi.exceptions import RequestValidationError
|
|
from fastapi.encoders import jsonable_encoder
|
|
from starlette.exceptions import HTTPException as StarletteHTTPException
|
|
from mangum import Mangum
|
|
from backend.app.portfolio import router as portfolio_router
|
|
from backend.app.whlg import router as whlg_router
|
|
from backend.app.plan import router as plan_router
|
|
from backend.app.tasks import router as tasks_router
|
|
from backend.app.bulk_uploads import router as bulk_uploads_router
|
|
from backend.app.dependencies import validate_api_key
|
|
from backend.app.config import get_settings
|
|
|
|
logger = logging.getLogger("uvicorn.error")
|
|
logging.basicConfig(level=logging.INFO)
|
|
|
|
if get_settings().ENVIRONMENT == "local":
|
|
app = FastAPI()
|
|
else:
|
|
app = FastAPI(dependencies=[Depends(validate_api_key)])
|
|
|
|
|
|
@app.exception_handler(RequestValidationError)
|
|
async def validation_exception_handler(request: Request, exc: RequestValidationError):
|
|
logger.error(f"422 Validation Error at {request.url}")
|
|
logger.error(f"Body: {exc.body}")
|
|
logger.error(f"Validation Errors: {exc.errors()}")
|
|
return JSONResponse(
|
|
status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
|
|
content=jsonable_encoder({"detail": exc.errors(), "body": exc.body}),
|
|
)
|
|
|
|
|
|
@app.exception_handler(StarletteHTTPException)
|
|
async def http_exception_handler(request: Request, exc: StarletteHTTPException):
|
|
logger.warning(f"{exc.status_code} Error at {request.url} - Detail: {exc.detail}")
|
|
return JSONResponse(
|
|
status_code=exc.status_code,
|
|
content={"detail": exc.detail},
|
|
)
|
|
|
|
|
|
@app.middleware("http")
|
|
async def log_requests(request: Request, call_next):
|
|
logger.info(f"Incoming request: {request.method} {request.url}")
|
|
response = await call_next(request)
|
|
logger.info(f"Response status: {response.status_code}")
|
|
return response
|
|
|
|
|
|
@app.get("/health")
|
|
async def health():
|
|
sha = os.getenv("GITHUB_SHA", "unknown")
|
|
logger.info(f"Health check OK - deployed sha={sha}")
|
|
return {"status": "ok", "sha": sha}
|
|
|
|
|
|
app.include_router(tasks_router.router, prefix="/v1")
|
|
app.include_router(portfolio_router.router, prefix="/v1")
|
|
app.include_router(plan_router.router, prefix="/v1")
|
|
app.include_router(whlg_router.router, prefix="/v1")
|
|
app.include_router(bulk_uploads_router.router, prefix="/v1")
|
|
|
|
if get_settings().ENVIRONMENT == "local":
|
|
from backend.app.local import router as local_router
|
|
|
|
app.include_router(local_router.router)
|
|
|
|
handler = Mangum(app)
|