mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
cd798d3513
`from_rdsap_schema_17_0` was an older copy that hardcoded a cluster of lodged `sap_heating` fields to None while every other API path (19.0/20.0/…) reads them from `schema.sap_heating`. PR #1380 restored the secondary-heating pair; this restores the rest of the same block, all of which `RdSapSchema17_0` lodges: MainHeatingDetail: boiler_flue_type, fan_flue_present, central_heating_pump_age, main_heating_index_number (PCDB efficiency index) SapHeating: cylinder_thermostat, cylinder_insulation_thickness Impact — cylinder_thermostat (12/23 local 17.0 fixtures) read as "no thermostat", so the water-heating worksheet over-applied its ×1.3 penalty and `recommend_cylinder_thermostat` could fire on a dwelling that already has one; cylinder_insulation_thickness (13/23) discarded the measured value so the cylinder-loss cascade fell back to age-band defaults; main_heating_index_number lost the PCDB efficiency lookup. Mirrors the 19.0 path exactly. secondary_*_type left untouched so this PR stays independent of #1380 (no overlapping lines). Adds a regression test asserting the whole block survives `from_api_response` on a real 17.0 cert. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| tests | ||
| __init__.py | ||
| epc.py | ||
| epc_codes.csv | ||
| epc_property_data.py | ||
| field_mappings.py | ||
| historic_epc.py | ||
| historic_epc_matching.py | ||
| mapper.py | ||