mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
e43ff79c77
The newer Elmhurst Summary export lodges a gas combi as §14.0 "Fuel Type" empty + "Main Heating SAP Code" 104 (EES "BGW"), with no fuel string. The site-notes mapper left `main_fuel_type=''`, so `cert_to_inputs` raised `MissingMainFuelType` — blocking the whole gas-combi Summary path (reproduced on the simulated 001431 case). SAP 10.2 Table 4b (PDF p.168) rows 101-119 are "Gas boilers (including mains gas, LPG and biogas)": the code fixes the boiler type/efficiency but NOT the carrier, so 104 alone can't distinguish mains gas from LPG. The disambiguator is §15.0 "Water Heating Fuel Type" — a combi/boiler heats space + water from one appliance — exactly mirroring the existing liquid-fuel (codes 120-141) fallback. `_elmhurst_gas_boiler_main_fuel` adopts the §15.0 carrier only when the SAP code is in 101-119 AND §15.0 resolves to a gas/LPG fuel, so a regular boiler + electric immersion (§15.0 = "Electricity") still strict-raises rather than mis-billing gas as electric. 2291 passed (+1), 0 failed; pyright net-zero on both files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| epc | ||
| magicplan | ||
| __init__.py | ||
| datatypes.py | ||
| enums.py | ||