mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
Review findings on PR #1527: - The objective is required (no sap_rating default) on _repair_to_target, _best_repair_candidate and _rescored_groups: every caller already passes it, and a default would let a future call path silently optimise SAP for a carbon/bill goal while pyright stayed green. The default stays on the public optimise_package / optimise_package_fabric_first entry points. - _best_repair_candidate hoists objective(current) out of the candidate loop: current is loop-invariant, so for the Energy-Savings bill objective this was one full BillDerivation.derive per candidate per repair iteration for the same score. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| abri | ||
| addresses | ||
| billing | ||
| bulk_document_download | ||
| data_transformation | ||
| elmhurst | ||
| epc | ||
| epc_prediction | ||
| fuel_rates | ||
| geospatial | ||
| magicplan | ||
| modelling | ||
| property | ||
| property_baseline | ||
| sap10_calculator | ||
| sap10_ml | ||
| tasks | ||
| building_geometry.py | ||
| postcode.py | ||