mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-12 13:29:04 +00:00
`_category_for` mapped room heaters / heat pumps / heat networks but returned None for electric-storage-heater codes (401-409), so a storage system override emitted `sap_main_heating_code=409` + `main_heating_category=None` while `_control_for` right beside it correctly set the storage charge control — an asymmetry. Map storage codes to category 7 so the overlaid cert is internally consistent (code 401-409 <-> category 7), matching the control/fuel/meter companions the overlay drags. Consistency follow-up to the modelling HHRSH off-peak-pricing fix (#1426): that PR's Table 12a resolver already prices any storage-coded system off-peak regardless of category, so this is NOT a live mispricing — it removes a latent code<->category inconsistency that other category-keyed logic (responsiveness, pumps/fans) could trip on. Tests: storage/HHRSH overlay tests now also assert `main_heating_category==7`. tests/domain/epc (347) + prediction/override/reclassify (118) green; source pyright-clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| test_attribute_overlay.py | ||
| test_construction_age_band_overlay.py | ||
| test_glazing_mix_guard.py | ||
| test_glazing_overlay.py | ||
| test_main_fuel_guard.py | ||
| test_main_fuel_overlay.py | ||
| test_main_heating_guard.py | ||
| test_main_heating_system_overlay.py | ||
| test_override_code_mapping.py | ||
| test_property_type_guard.py | ||
| test_roof_party_ceiling_guard.py | ||
| test_roof_type_overlay.py | ||
| test_wall_type_overlay.py | ||
| test_water_heating_guard.py | ||
| test_water_heating_overlay.py | ||