mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
3614c14bf5
Closes the final `sap_windows: LEN 7 vs 3` divergence by replacing
the cohort 000477 hand-built's glazing-type-collapsed 3-window
encoding with 7 SapWindow entries mirroring the Summary §11 1:1 —
the same row breakdown the Elmhurst mapper extracts. Total area per
glazing-type group is preserved (cascade-equivalent):
g=0.72/U=2.0: 8.04 m² total — was 2 rows (E 1.28 + W 6.76),
now 6 rows (E 1.28 + W [1.8 + 1.7 + 1.36 + 1.36 + 0.54])
g=0.76/U=2.8: 1.17 m² in 1 row (unchanged)
Cohort 000477 is a single-bp dwelling, so every window's
`window_location` is "Main" — no per-bp apportionment complexity.
Cascade output unchanged: all 11 `_FIXTURE_PINS["000477"]` SapResult
pins remain GREEN at 1e-4 against worksheet `SAP value 65.0057`.
**Cohort 000477 is now fully Layer-2 GREEN** —
`test_from_elmhurst_site_notes_matches_hand_built_000477` passes with
zero load-bearing divergences between the mapped EpcPropertyData
(from `Summary_000477.pdf`) and the hand-built fixture.
Full sweep: 103 passed (was 102 pre-Slice-71; +1 new diff test),
10 failed (same 10 001479-related as documented in the handover).
Pyright net-zero on the touched fixture.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| src/domain | ||
| pyproject.toml | ||
| README.md | ||
domna-domain
Shared domain types — Property, Properties, BaselinePerformance, Plan, PlanPhase, Scenario, ScenarioPhase, ScenarioSnapshot, Recommendation, OptimisedPackage, EpcPropertyData, etc.
Boundary: types only. No persistence, no IO, no business logic. Other packages and services depend on domna-domain; this package depends on nothing internal.
Domain definitions live in ../../CONTEXT.md. New types added here must match the glossary terms.
Layout
src/domain/
├── __init__.py
├── property.py # Property, Properties, PropertyIdentity
├── site_notes.py
├── landlord_overrides.py
├── baseline_performance.py # lodged + effective pair (ADR-0004)
├── plan.py # Plan, PlanPhase, OptimisedPackage
├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005)
├── recommendation.py
├── geospatial.py
├── solar.py
├── anomaly_flags.py
└── ml/
├── __init__.py
├── transform.py # EpcMlTransform (versioned per §8.3)
└── schema.py
When datatypes/epc/domain/ folds in, the EPC schema types move under src/domain/epc/.