mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-06-08 11:17:27 +00:00
7f17de84aa
Two mapper extensions, both validated by 000490 closing to 1e-4: 1. Secondary heating extraction. Elmhurst Summary PDFs lodge the secondary heating SAP code in the §14.1 Main Heating2 sub-section (between "14.1 Main Heating2" and "14.1 Community Heating") — not in the §14.0 Main Heating1 block where the main system lives. `ElmhurstMainHeating` gains a `secondary_heating_sap_code` field; the extractor reads it from the right section; the mapper threads it through to `SapHeating.secondary_heating_type`. The cascade then applies Table 11's 10% secondary fraction. 2. Sheltered-sides derivation per RdSAP §S5. The Summary PDF doesn't lodge per-dwelling sheltered-sides; the value is derived from built-form (Detached=0, Semi-Detached=1, End-Terrace=1, Mid- Terrace=2, Enclosed Mid-Terrace=3, Enclosed End-Terrace=2). `_map_elmhurst_ventilation` now takes built_form and populates `SapVentilation.sheltered_sides`. The table is cross-checked against U985-0001-NNNNNN.pdf line (19) across the 6 worksheet fixtures. Cohort SAP deltas after this slice (target 1e-4): 000474 0.0000 ✓ Slice 47 000477 +2.6555 diagnosis pending (lighting bulb count diff) 000480 +4.1955 diagnosis pending 000487 +4.4553 extractor still drops most windows 000490 0.0000 ✓ THIS SLICE 000516 +1.5162 roof-window separation Pyright net-zero on touched files (35 errors, same baseline). 755 tests pass (up from 754 — new `test_summary_000490_full_chain_sap_ matches_worksheet_pdf_exactly`). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| epc | ||
| magicplan | ||
| __init__.py | ||
| datatypes.py | ||
| enums.py | ||