mirror of
https://github.com/Hestia-Homes/Model.git
synced 2026-07-27 23:35:01 +00:00
f0f9c8d8d7
Sets HISTORIC_EPC_S3_ROOT, the env var the handler reads to build the historic-EPC
reader. With it set, an EPC-less Property whose expired pre-2012 certificate is in
the backup has its prediction conditioned on that certificate and persisted as
source="expired" rather than "predicted" — which is what lets reporting tell "no EPC
at all" apart from "only an expired one".
The bucket comes from the shared remote state rather than a rebuilt string:
`retrofit_sap_data_bucket_name` is — despite the name — the retrofit-data-<stage>
bucket (shared/main.tf:167), and engine and fast-api already read it from that output.
modelling_e2e was the outlier hardcoding "retrofit-data-${var.stage}".
No IAM change: modelling_e2e_s3_read already grants GetObject + ListBucket across the
whole retrofit-data-<stage> bucket, which covers historical_epc/.
Note this makes 'expired' rows start appearing once deployed. assessment-model's
epcSources.ts joins only 'lodged' and 'predicted', so until it addresses the predicted
slot — source IN ('predicted','expired') — an 'expired' row matches neither and the
home drops out of both the "Homes Without an EPC" and "Expired EPCs" cards.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
||
|---|---|---|
| .. | ||
| _template | ||
| abri_api | ||
| address2UPRN | ||
| audit_generator | ||
| bulk_address2uprn_combiner | ||
| bulk_document_download | ||
| bulkUploadFinaliser | ||
| categorisation | ||
| condition-etl | ||
| ecmk_to_ara | ||
| engine | ||
| fast-api | ||
| hubspot_deal_etl | ||
| landlordDescriptionOverrides | ||
| magic_plan | ||
| modelling_e2e | ||
| ordnanceSurvey | ||
| pashub_to_ara | ||
| postcodeSplitter | ||
| sharepoint_renamer | ||